[release/9.0] Add more specific messages when pending model changes are detected #35221
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35133
Addresses comments in #34431, #35080 and #35181
Description
EF offers a way of updating the database schema to match the current model via incremental migrations. The common scenario is to add a new migration, then update the database to the latest migration. But it is easy to forget adding a new migration after the model was changed. So, in 9.0 we added a runtime warning that would throw by default when updating the database if there are any changes detected in the model that aren't reflected in the latest migration.
However, there are several reasons why the migrations could be out-of-date and the exception message was not helpful for some of the users. This PR adds more specific messages and makes the warning to be logged instead of throwing for some cases:
new DateTime()
orGuid.NewGuid()
are used in seed data. The exception will still be thrown.We will also add documentation explaining the above.
Customer impact
After the upgrade some applications that were working correctly started crashing on startup. This was by-design, but the required action from the developer wasn't clear. The workaround is to ignore the warning using options.
How found
Multiple customer reports on 9.
Regression
Yes, from 8.
Testing
Tests added.
Risk
Low.