(RC2) Persist Id values into owned collection JSON documents
#34478
+475
−267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @artl93 |
AndriySvyryd
approved these changes
Aug 20, 2024
AndriySvyryd
changed the title
Id values into owned collection JSON documents (#34466)Id values into owned collection JSON documents
* Persist `Id` values into owned collection JSON documents Fixes #29380 There are several aspects to #29380: - Constructor binding (already fixed) - Round-tripping the `Id` property value (addressed by this PR) - Persisting key values in JSON collection documents (tracked by #28594) I investigated persisting key values, but identity lookup requires key values in the materializer before we do the parsing of the document. This means persisted key values are not available without re-writing this part of the shaper, which we can't do for 9. To fix the main issue (round-trip `Id`) this PR changes the way identity on owned JSON collection documents works. Instead of discovering and using the `Id` property, we treat it like any other property. We then create a shadow `__synthesizedOrdinal` property to act as the ordinal part of the key. We need to discuss: - Is this breaking for any scenario that was working before? - Does this put us in a bad place for the future of owned types with explicit keys? * Added validation of no explicit keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports #34466 to 9.0
Fixes #29380
Description
Persisting entity types with an
Idproperty did not work in previous releases of EF Core. This was an adoption blocker for many, as can be seen by the GitHub votes. This change is a targeted fix for 9 that allowsIdproperties to be persisted. It is too risky for 9 to do the wider fix of allowing key properties to be persisted.Customer impact
Fixes a major adoption blocker for use of JSON in relational databases.
How found
Many customer reports
Regression
No
Testing
Idproperty added to existing model used by hundreds of tests.Risk
Medium. This changes the model built, which we have discussed and analyzed and we think it's okay, especially since the model that was being built before was not valid. However, the model is used everywhere and it could have some impact that we have missed.