[release/8.0] Preserve unicodeness and fixed-lengthiness in compiled model. #32683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
changed the title
|
@AndriySvyryd can you get this reviewed? I can merge once it is |
maumar
approved these changes
Jan 4, 2024
ajcvickers
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32617
Port of #32662
Description
In EF 8 we augmented the generated compiled model with type mappings, however some aspects weren't preserved, in particular whether a given string property accepts Unicode and whether it has a fixed length.
Customer impact
When using a compiled model with unicode properties queries involving those properties will use non-unicode behavior, potentially resulting in data corruption.
How found
Customer report on 8.0.
Regression
Yes.
Testing
Tests added.
Risk
Low.