Model validation for primitive collections #31680
Conversation
src/EFCore.Relational/Query/RelationalQueryableMethodTranslatingExpressionVisitor.cs
Show resolved
Hide resolved
|
@roji Well, that was fun. Turs out there was a significant bug where the element type from the type mapping never made it to the |
ajcvickers
force-pushed
the
230910_StringCheese
branch
from
01c31a1 to
d158b09
Compare
| /// See <see href="https://aka.ms/efcore-docs-conventions">Model building conventions</see> for more information and examples. | ||
| /// </para> | ||
| /// </remarks> | ||
| public class ElementMappingConvention : IModelFinalizingConvention |
There was a problem hiding this comment.
Merge this into type mapping convention
There was a problem hiding this comment.
@AndriySvyryd What do you mean by "type mapping convention?"
There was a problem hiding this comment.
Oh, looks like we've removed it already. This can also be calculated in Property, but this can be done post-8.0
There was a problem hiding this comment.
Yes, I think this needs to get revisited after 8. Related #31417.
| VerifyError( | ||
| CoreStrings.IdentifyingRelationshipCycle("A -> B"), | ||
| modelBuilder); | ||
| VerifyError(CoreStrings.RelationshipCycle("B", "AId", "ValueConverter"), modelBuilder); |
There was a problem hiding this comment.
Why did the exception change?
There was a problem hiding this comment.
Because type mapping now attempts to determine keys before getting to the validation, and this detects the same cycle and throws.
ajcvickers
force-pushed
the
230910_StringCheese
branch
from
d158b09 to
77cdfd2
Compare
Fixes #31617