Stop instantiating Stopwatch #31348
Merged
Stop instantiating Stopwatch #31348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
changed the title
roji
commented
Jul 25, 2023
roji
commented
Jul 25, 2023
| #if NET7_0_OR_GREATER | ||
| => Stopwatch.GetElapsedTime(startTimestamp); | ||
| #else | ||
| => new((long)((Stopwatch.GetTimestamp() - startTimestamp) * StopWatchTickFrequency)); |
There was a problem hiding this comment.
Copied from the .NET 7.0 implementation
sharwell
reviewed
Jul 25, 2023
AndriySvyryd
approved these changes
Jul 26, 2023
sharwell
reviewed
Jul 26, 2023
|
@AndriySvyryd @bricelam simplified this thanks to @sharwell's suggestion, will wait in case you want to take another look etc. |
|
OK, will merge this - let me know retroactively if you see any issues. |
sharwell
reviewed
Aug 7, 2023
| @@ -155,12 +154,12 @@ public override bool NextResult() | |||
| { | |||
| stmt = _stmtEnumerator.Current; | |||
|
|
|||
| _timer.Start(); | |||
There was a problem hiding this comment.
📝 If you're ever interested in adding more of the API, you can reference some old work here:
dotnet/roslyn@ce6b1a9
It wasn't worth the complexity for our uses, so you would make the call. Good to leave a note for future reference though. 😄
There was a problem hiding this comment.
Thanks @sharwell, yeah - I think the current thing more than fits our needs...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #31347
Closes #26295
/cc @vonzshik