Refactor internal usage analyzer #30767
Conversation
|
Hello @roji! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:
These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check. Give feedback on thisFrom the bot dev teamWe've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments. Please reach out to us at [email protected] to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin. |
ghost
removed
the
| } | ||
| } | ||
|
|
||
| private static void AnalyzeMember(OperationAnalysisContext context, ISymbol symbol) | ||
| { | ||
| // ReSharper disable once RedundantCast | ||
| if ((object)symbol.ContainingAssembly == context.Compilation.Assembly) | ||
| if (symbol.ContainingAssembly?.Equals(context.Compilation.Assembly, SymbolEqualityComparer.Default) == true) |
There was a problem hiding this comment.
Why the null checks? ContainingAssembly is annotated as non-nullable, no?
There was a problem hiding this comment.
CI failed without it. See results of previous commit (e.g. https://github.com/dotnet/efcore/runs/13032979328)
ContainingAssembly is annotated as non-nullable, no?
Unfortunately, this part of ISymbol isn't null-annotated: https://github.com/dotnet/roslyn/blob/28f2063999e5e7d91d7159e9089c8c9c0c193b91/src/Compilers/Core/Portable/Symbols/ISymbol.cs#L66-L97
|
Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:
These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check. Give feedback on thisFrom the bot dev teamWe've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments. Please reach out to us at [email protected] to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin. |
1 similar comment
|
Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:
These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check. Give feedback on thisFrom the bot dev teamWe've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments. Please reach out to us at [email protected] to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin. |
ghost
merged commit 
|
Thanks for your contribution @DoctorKrolic! |
Removed HACK with target-typed new since the underlying roslyn analyzers issue has been fixedChanged comment to reference new roslyn-analyzers issue 🫤objectwas used.ctorstring use well-known members API to improve readabilityThese changes are very minor and don't affect any sort of behaviour, therefore I didn't create an issue upfront.