Avoid considering unchanged properties as modified #30640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajcvickers
approved these changes
Apr 6, 2023
AndriySvyryd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30601
Description
Starting with 7.0 EF compares the original store value with the current one when persisting a modified property, but due to a bug the comparison almost always returned
falseeven if the values should be treated as equal.Customer impact
In the reported case it results in an exception, because the properties appear to create a dependency cycle when treated as if they are modified.
How found
Customer report on 7.0
Regression
Yes
Testing
Added a test for the impacted scenario.
Risk
Low. Added quirk to revert to old behavior if necessary.