Remove unnecessary dependency on MS.CA.VB package

[DoctorKrolic]

This PR does not fix any bugs or add new features and is very small in size, so I think, it doesn't need an issue to be opened first. I just notecied, that for whatever reason analyzer tests have a dependency on a VB package, while the analyzers themselves are for C# only. I verified, that removing this dependency doesn't break test execution locally. If there is some mysterious sense in having this dependency, I won't regret if the PR gets closed. It actually took more time to setup EF repo on my machine than the time taken by the actual change...

[roji]

@DoctorKrolic at least in principle, the analyzers are supposed to work for VB code as well (e.g. warn for internal API usage). This should be validated by tests, though I don't think we've ever gone through the trouble of writing them.

[DoctorKrolic]

Both current analizers are C#-only:

efcore/src/EFCore.Analyzers/InternalUsageDiagnosticAnalyzer.cs

Lines 12 to 13 in 36e9a9e

	[DiagnosticAnalyzer(LanguageNames.CSharp)]
	public sealed class InternalUsageDiagnosticAnalyzer : DiagnosticAnalyzer

efcore/src/EFCore.Analyzers/UninitializedDbSetDiagnosticSuppressor.cs

Lines 11 to 12 in 36e9a9e

	[DiagnosticAnalyzer(LanguageNames.CSharp)]
	public sealed class UninitializedDbSetDiagnosticSuppressor : DiagnosticSuppressor

The analizer project doesn't target VB compiler package at all.
I mean, why should we pay cost of downloading and linking package that is not actually used for every local/CI test build?

[roji]

I mean, why should we pay cost of downloading and linking package that is not actually used for every local/CI test build?

I agree the package isn't needed, but don't you think that's very negligible, considering this is a test-only dependency anyway?

[DoctorKrolic]

don't you think that's very negligible

Yes, but the cost of review is basically 0 as well. All CI is green, so I can be trusted now, that this doesn't break anything)

[roji]

Sure. But we generally don't do merge commits; can you please rebase your change on the latest main, as a single commit without merge branches? You can force-push that to this PR's branch.

[DoctorKrolic]

@roji You can probably merge this PR

[roji]

Thanks