[release/7.0] Update discriminator columns when PK-to-PK dependent type is changed #29920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
changed the title
AndriySvyryd
approved these changes
Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of #29876
Fixes #29789
Description
EF generates an update when a dependent entity is deleted and replaced with a new entity that has the same PK. If that new entity is of a different type, then the discriminator column must be updated, but this is not happening in EF7.
Customer impact
Database contains rows that represent the wrong type of object; so potentially data corruption.
How found
Customer reported on 7.0
Regression
Yes, from EF Core 6.0.
Testing
Added tests for the affected scenario and related.
Risk
Low; the fix is simple, and a quirk was added to revert back to older behavior.