[release/7.0] Allow underscores in identifiers again #29822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maumar
reviewed
Dec 10, 2022
| @@ -1455,10 +1455,11 @@ private static bool IsIdentifierPartCharacter(char ch) | |||
| { | |||
| if (ch < 'a') | |||
| { | |||
| return ch < 'A' | |||
| return (ch < 'A' | |||
There was a problem hiding this comment.
It's hard to turn on quirks when running tools. Also, it's just reverting to code to what it was before 7.0
There was a problem hiding this comment.
Fwiw, I have only had two reports on this in Power Tools
ajcvickers
approved these changes
Dec 12, 2022
AndriySvyryd
added
Servicing-consider
Servicing-approved
and removed
Servicing-consider
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of #29821
Fixes #29450
Description
A change in the validation of identifier names resulted in an unintentional breaking change.
Customer impact
If the generated files would contain underscores the customer needs to add them manually to allow them to compile against existing code.
How found
Customer reported on 7.0
Regression
Yes.
Testing
Adjusted the tests for the affected scenario
Risk
Low; the fix reverts the affected code to the 6.0 version.