Don't duplicate query filter parameters

[stevendarby]

• Checks for an already added parameter with an equal expression and uses that parameter name without adding another
• Comparing the parameter to a slightly different type still produces a separate parameter in SQL Server as test shows

Fixes #24476

• I've read the guidelines for contributing and seen the walkthrough
• I've posted a comment on an issue with a detailed description of how I am planning to contribute and got approval from a member of the team
• The code builds and tests pass locally (also verified by our automated build checks)
• Commit messages follow this format:

        Summary of the changes
        - Detail 1
        - Detail 2

        Fixes #bugnumber

• Tests for the changes have been added (for bug fixes / features)
• Code follows the same patterns and style as existing code in this repo

[stevendarby]

If there's anything I need to do to move this along, let me know. If it's just that other things are taking a priority, that's fine!

[smitpatel]

Bad implementation

[stevendarby]

Is the failed build an environmental issue? Looks like it cancelled after waiting 3 hours. Not sure if it can be retried without another push.

Edit: failed again, so might be due to a change in my PR after all. All builds ok locally so a bit stumped.
Edit 2: it's now working 🤷

[stevendarby]

@smitpatel thanks for initial review, changes are much simpler now.

[stevendarby]

@maumar this post here may be useful for understanding how I arrived at these changes: #29422 (comment) - thanks

[stevendarby]

@maumar any feedback?

[stevendarby]

@ajcvickers is this likely to get reviewed again anytime soon? After @smitpatel's feedback, the changes are quite small and I'm fairly confident in them.

[ajcvickers]

@stevendarby We will get to it when we can, but since Smit is no longer on the team it is taking some time.

[stevendarby]

@ajcvickers ah I see, thanks for the update

[stevendarby]

@maumar sorry to pester, but now the 8.0 previews have begun I was just thinking it'd be great to get it into one; and just aware that another 5 months will be too late. Is there any chance of a review over the next few weeks?

[maumar]

@stevendarby I'm planning to take a look at it this week. Apologies for the long delay.

feedback addressed

[maumar]

@stevendarby thank you for the contribution!