Allow users to always use transactions with SaveChanges #28711
Conversation
| /// Transactions are automatically created as needed. For example, most single SQL statements are implicitly executed within a | ||
| /// transaction, and so do not require an explicit one to be created, reducing database round trips. This is the default setting. | ||
| /// </summary> | ||
| WhenNeeded, |
There was a problem hiding this comment.
Could also add a flag WhenNotInvokingStoredProcedure to avoid having to add the metadata
There was a problem hiding this comment.
Ah, you mean #28511? Writing some thoughts about the idea: #28511 (comment)
roji
force-pushed
the
EnableAutoTransactions
branch
from
9217f50 to
a2a08df
Compare
Obsoletes AutoTransactionsEnabled, replacing it with a new 3-valued enum. Closes dotnet#27574
roji
force-pushed
the
EnableAutoTransactions
branch
from
a2a08df to
089eda8
Compare
|
Hello @roji! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:
These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check. Give feedback on thisFrom the bot dev teamWe've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments. Please reach out to us at [email protected] to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin. |
ghost
merged commit 
To avoid a new flag which would be weird with the existing AutoTransactionsEnabled (e.g. AutoTransactionsEnabled=false, newflag=true), I went with the controversial choice of obsoleting AutoTransactionsEnabled and replacing it with an AutoTransactionBehavior enum that has WhenNeeded (default), Never, Always. Before you start hating, remember we almost decided to remove AutoTransactionsEnabled because it's obscure and nobody uses it (or should)...
Closes #27574