-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metadata work for json. #28540
Metadata work for json. #28540
Conversation
src/EFCore.Relational/Extensions/RelationalEntityTypeExtensions.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Extensions/RelationalPropertyExtensions.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Extensions/RelationalOwnedNavigationBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
bef2af8
to
881aae2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's a 1st round of comments from me. There are some questions we may want to discuss in design (e.g. distinction between columns and JSON properties, whether JSON properties should be represented as columns in the relational model).
src/EFCore.Relational/Extensions/RelationalEntityTypeExtensions.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Extensions/RelationalNavigationBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Extensions/RelationalOwnedNavigationBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Extensions/RelationalPropertyBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Metadata/Conventions/RelationalMapToJsonConvention.cs
Outdated
Show resolved
Hide resolved
...e.Relational/Metadata/Conventions/RelationalNavigationJsonPropertyNameAttributeConvention.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Metadata/Conventions/SharedTableConvention.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Extensions/RelationalEntityTypeExtensions.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Extensions/RelationalEntityTypeExtensions.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Extensions/RelationalEntityTypeExtensions.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Extensions/RelationalEntityTypeExtensions.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Extensions/RelationalNavigationExtensions.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Extensions/RelationalPropertyExtensions.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Infrastructure/RelationalModelRuntimeInitializer.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Infrastructure/RelationalModelRuntimeInitializerDependencies.cs
Outdated
Show resolved
Hide resolved
...Relational/Metadata/Conventions/Infrastructure/RelationalConventionSetBuilderDependencies.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Metadata/Conventions/RelationalRuntimeModelConvention.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Infrastructure/RelationalModelValidator.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Infrastructure/RelationalModelValidator.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Metadata/Internal/RelationalForeignKeyExtensions.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Metadata/Internal/RelationalForeignKeyExtensions.cs
Show resolved
Hide resolved
src/EFCore.Relational/Metadata/Internal/RelationalKeyExtensions.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Metadata/Internal/RelationalKeyExtensions.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Migrations changes LGTM
src/EFCore.SqlServer/Design/Internal/SqlServerAnnotationCodeGenerator.cs
Outdated
Show resolved
Hide resolved
1162406
to
0edb97c
Compare
Add a JSON column to |
Add a test to |
src/EFCore.Relational/Extensions/Internal/RelationalPropertyInternalExtensions.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Extensions/Internal/RelationalPropertyInternalExtensions.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Extensions/Internal/RelationalPropertyInternalExtensions.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Extensions/Internal/RelationalPropertyInternalExtensions.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Infrastructure/RelationalModelValidator.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Extensions/Internal/RelationalPropertyInternalExtensions.cs
Outdated
Show resolved
Hide resolved
ae45d85
to
e7d1bf4
Compare
…ier. This PR includes: - builder methods, - conventions, - relational model, - model validation, - migrations, - update
Separated from main PR to make the review easier.
This PR includes: