Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: Introduce EnumerableExpression which is not SQL token #27969

Merged
merged 1 commit into from
May 10, 2022
Merged

Query: Introduce EnumerableExpression which is not SQL token #27969

merged 1 commit into from
May 10, 2022

Commits on May 10, 2022

  1. Query: Introduce EnumerableExpression which is not SQL token 

    This iterates over design in #27931

- Bring back DistinctExpression (yes the token in invalid in some places and incorrect tree will throw invalid SQL error in database
- Introduce EnumerableExpression which is a holder/parameter object which contains facets of grouping element chain including Distinct/Predicate/Selector/Ordering
- Translators are responsible for putting together pieces from EnumerableExpression to generate a SqlExpression as a result
- Remove GroupByAggregateChainProcessor which failed to avoid double visitation. We need to refactor this code in future to avoid it when we implement public API for aggregate functions

Resolves #27948
Resolves #27935
    @smitpatel
    smitpatel committed May 10, 2022
    Configuration menu
    Copy the full SHA
    c9c18bb View commit details
    Browse the repository at this point in the history