[6.0.1] Cosmos: Use configured serializer when reading #26702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
changed the title
AndriySvyryd
force-pushed
the
Issue26690
branch
from
7908306 to
9e20e72
Compare
maumar
approved these changes
Nov 16, 2021
ajcvickers
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26690
Description
When converting JSON values to
DateTimewe are using the default serializer that converts UTC times to local. However in #25741 we changed the serializer options used for saving the values, causing them to no longer round-trip.Customer impact
The queried
DateTimevalues are now in local time. Depending on the app logic this can result in data corruption.How found
Customer reported on 6.0
Regression
Yes, this worked in 5.0
Testing
Added test for this scenario.
Risk
Low, the change just make sure to use the existing serializer consistently. Also added a quirk mode.