Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MigrationsSqliteTest tests #26572

Merged
merged 1 commit into from
Nov 8, 2021
Merged

Fix MigrationsSqliteTest tests #26572

merged 1 commit into from
Nov 8, 2021

Conversation

bobbyangers
Copy link
Contributor

@bobbyangers bobbyangers commented Nov 8, 2021 •
edited
Loading

Correct tests to call correct base class method

  • Create_sequence
  • Create_sequence_all_settings
  • Alter_sequence_all_settings
  • Alter_sequence_increment_by
  • Drop_sequence
  • Rename_sequence
  • Move_sequence

Fixes #26571

  • I've read the guidelines for contributing and seen the walkthrough
  • I've posted a comment on an issue with a detailed description of how I am planning to contribute and got approval from a member of the team
  • The code builds and tests pass locally (also verified by our automated build checks)
  • Commit messages follow this format:
        Summary of the changes
        - Detail 1
        - Detail 2

        Fixes #bugnumber
  • Tests for the changes have been added (for bug fixes / features)
  • Code follows the same patterns and style as existing code in this repo

@bobbyangers
Summary of the changes
8c8237c 
Correct tests to call correct base class method
- Create_sequence
- Create_sequence_all_settings
- Alter_sequence_all_settings
- Alter_sequence_increment_by
- Drop_sequence
- Rename_sequence
- Move_sequence

Fixes dotnet#26571
@bobbyangers bobbyangers force-pushed the dev/rangers-sqlite-26571 branch from eceb2e0 to 8c8237c Compare November 8, 2021 14:56
roji
roji approved these changes Nov 8, 2021
View reviewed changes
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bobbyangers, this looks like a silly copy-pasta mistake I did...

@roji roji changed the title Summary of the changes Fix MigrationsSqliteTest tests Nov 8, 2021
@roji roji merged commit c5aa799 into dotnet:main Nov 8, 2021
@bobbyangers bobbyangers deleted the dev/rangers-sqlite-26571 branch November 8, 2021 16:41
@ajcvickers ajcvickers mentioned this pull request Nov 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roji roji roji approved these changes

Assignees
No one assigned
Labels
community-contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MigrationsSqliteTest xxx_sequence not calling the correct base class
3 participants
@bobbyangers @roji @ajcvickers