Make Projection_AsEnumerable_projection deterministic

[roji]

No description provided.

[smitpatel]

This is not required. The collection is unordered by design. The result assertion will (or should) sort it before checking results.

[roji]

@smitpatel can you say how you'd like this to be fixed? The test has assertOrder: true, so if I understand things right, results coming back from the database are expected to match in-memory results (entity sorters are not applied). So where do you want the sorting to occur?

[smitpatel]

The assert order is to make sure that the customer (outer type) is sorted since query specify sort order on it. The inner element or the result is collection of orders without any window and order by so it should be just collection of orders without any ordering. So the query does not need update. You need to update the code to verify result to do matching of 2 unordered collection.

[maumar]

        return AssertQuery(
            async,
            ss => ss.Set<Customer>()
                .Where(c => c.CustomerID.StartsWith("A"))
                .OrderBy(c => c.CustomerID)
                .Select(c => ss.Set<Order>().Where(o => o.CustomerID == c.CustomerID).AsEnumerable())
                .Where(e => e.Where(o => o.OrderID < 11000).Count() > 0)
                .Select(e => e.Where(o => o.OrderID < 10750)),
            assertOrder: true,
            elementAsserter: (e, a) => AssertCollection(e, a, elementSorter: ee => ee.OrderID),
            entryCount: 18);

[ghost]

Hello @roji!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

[ghost]

Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:

1. Azure Pipelines

These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check.

Give feedback on this

From the bot dev team

We've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments.

Please reach out to us at [email protected] to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin.

Addressed