Fix to #19883 - Query: null semantics should keep track of columns that are guaranteed to be null and remove redundant IS NULL/ IS NOT NULL checks #25951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
reviewed
Sep 10, 2021
smitpatel
reviewed
Sep 10, 2021
smitpatel
reviewed
Sep 10, 2021
maumar
force-pushed
the
fix19883
branch
3 times, most recently
from
e84e5c2 to
a35e23f
Compare
|
@smitpatel ping |
smitpatel
reviewed
Sep 14, 2021
| @@ -476,6 +484,9 @@ protected virtual SqlExpression VisitCase(CaseExpression caseExpression, bool al | |||
| nullable |= elseResultNullable; | |||
| } | |||
|
|
|||
| RestoreNonNullableColumnsList(currentNonNullableColumnsCount); | |||
smitpatel
approved these changes
Sep 14, 2021
…at are guaranteed to be null and remove redundant IS NULL/ IS NOT NULL checks Adding a list of columns guaranteed to be null in the given subtree. When processing right side of the || operator, we can convert those to non-nullable columns and therefore improve the generated sql. Fixes #19883 Fixes #19410
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a list of columns guaranteed to be null in the given subtree. When processing right side of the || operator, we can convert those to non-nullable columns and therefore improve the generated sql.
Fixes #19883
Fixes #19410