Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump SQLitePCLRaw to 2.0.6 #25730

Merged
merged 1 commit into from
Sep 7, 2021
Merged

Bump SQLitePCLRaw to 2.0.6 #25730

merged 1 commit into from
Sep 7, 2021

Conversation

bricelam
Copy link
Contributor

No description provided.

@bricelam bricelam requested a review from a team August 26, 2021 16:57
@bricelam
Copy link
Contributor Author

@wtgodbe Can we mirror the 2.0.5 versions of the following packages?

  • SQLitePCLRaw.bundle_e_sqlcipher
  • SQLitePCLRaw.bundle_e_sqlite3
  • SQLitePCLRaw.bundle_sqlite3
  • SQLitePCLRaw.bundle_winsqlite3
  • SQLitePCLRaw.core
  • SQLitePCLRaw.lib.e_sqlcipher
  • SQLitePCLRaw.lib.e_sqlite3
  • SQLitePCLRaw.provider.e_sqlcipher
  • SQLitePCLRaw.provider.e_sqlite3
  • SQLitePCLRaw.provider.sqlite3
  • SQLitePCLRaw.provider.winsqlite3

@wtgodbe
Copy link
Member

wtgodbe commented Aug 26, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ericsink
Copy link

@bricelam I plan to be available to provide short turnaround on any fixes needed for your release cycle. Please let me know if you need anything.

@gdoron
Copy link

gdoron commented Aug 29, 2021

@bricelam
Not specific to just this Pull request, but I'm wondering why MSFT itself doesn't seem to work with nuget's Directory.Packages.props file.

@bricelam
Copy link
Contributor Author

bricelam commented Sep 2, 2021

@gdoron I'd love to, but my top priority is keeping arcade and (if possible) dependabot happy. 😉

@bricelam
Copy link
Contributor Author

bricelam commented Sep 2, 2021

Looks like our CI is hitting ericsink/SQLitePCL.raw#445

@ericsink
Copy link

ericsink commented Sep 2, 2021

2.0.6-pre20210902144138 should fix that. Do you want to try it and then if it works I'll release it as 2.0.6 (non-pre)? The only diff from 2.0.5 is that the linux builds were done on ubuntu 18.04.

@dougbu
Copy link
Member

dougbu commented Sep 2, 2021

I'll release it as 2.0.6 (non-pre)?

Time is tight because we need to shut down 6.0 relatively soon and can't ship non-preview packages that depend on previews. But, this should work if 2.0.6-pre20210902144138 does. Right @bricelam

@bricelam
Copy link
Contributor Author

bricelam commented Sep 2, 2021

@wtgodbe Can we mirror the 2.0.6-pre20210902144138 versions of the packages?

@wtgodbe
Copy link
Member

wtgodbe commented Sep 2, 2021

@wtgodbe Can we mirror the 2.0.6-pre20210902144138 versions of the packages?

Done

@ericsink
Copy link

ericsink commented Sep 3, 2021

FYI, my test suites are passing on ubuntu 16.04, 18.04, and 20.04. So I'm going to proceed with my 2.0.6 release. It's building now and will get pushed to nuget.org when the ci is done. It is still true that nothing has changed except the linux builds of e_sqlite3 and e_sqlcipher.

@bricelam bricelam changed the title Bump SQLitePCLRaw to 2.0.5 Bump SQLitePCLRaw to 2.0.6-pre20210902144138 Sep 3, 2021
@bricelam bricelam removed the blocked label Sep 3, 2021
@bricelam
Copy link
Contributor Author

bricelam commented Sep 3, 2021

Success! As always, thank you for your help on this, Eric.

@dougbu
Copy link
Member

dougbu commented Sep 4, 2021

v2.0.6 packages are now available on NuGet. Can we move there to avoid another update before RTM❔

Separately, will likely need the following in dependabot.yml. Same for any other dependencies controlled there and used in product projects. Updates will otherwise violate dependency rules once we stabilize versions for v6.0.0.

    ignore:
      - dependency-name: "SQLitePCLRaw*"
        update-types: ["version-update:semver-patch"]

@gdoron
Copy link

gdoron commented Sep 4, 2021

@bricelam we are using it and dependabot, and they work perfectly fine together. FYI.

dependabot/dependabot-core#1880

@bricelam
Copy link
Contributor Author

bricelam commented Sep 7, 2021

@wtgodbe Can we mirror the 2.0.6 versions of the packages?

@bricelam bricelam changed the title Bump SQLitePCLRaw to 2.0.6-pre20210902144138 Bump SQLitePCLRaw to 2.0.6 Sep 7, 2021
@wtgodbe
Copy link
Member

wtgodbe commented Sep 7, 2021

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants