Fix to #25013 - Outstanding work for temporal tables #25563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maumar
commented
Aug 18, 2021
| Assert.Equal("mySchema", orders[SqlServerAnnotationNames.TemporalHistoryTableSchema]); | ||
| }); | ||
|
|
||
| // TODO: we could avoid creating the schema if we peek into the model |
There was a problem hiding this comment.
I'm thinking that looking into the model seems like too much work. Keeping the test in case we change our mind (or do disagree already and think we should do it?)
AndriySvyryd
approved these changes
Aug 18, 2021
|
You need to switch the target branch if you want this to go into rc1 |
|
+1 to put this in rc1 |
Removing unnecessary temporal annotations on runtime entity types, also avoiding adding EnsureSchemaOperation if the schema that is to be created has already been added in the migration batch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing unnecessary temporal annotations on runtime entity types, also avoiding adding EnsureSchemaOperation if the schema that is to be created has already been added in the migration batch.