[release/3.1] Update SQLite dependencies to 2.0.4 #25550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
changed the title
bricelam
approved these changes
Aug 17, 2021
|
@wtgodbe Is the 3.1 servicing branch currently open for approved fixes? Or are we waiting? (I should know, sorry! 😄) |
|
Branches are closed at the moment, we'll re-open 1 week before September patch tuesday |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25497
Description
Update dependency on external SQLite packages from 2.0.2 to 2.0.4. This version fixes an important bug System.AccessViolationException at System.Text.UTF8Encoding.GetCharCount(Byte*, Int32, System.Text.DecoderNLS) which has been hit by many customers. Our 5.0 packages have already depended on this newer version for about a year. We now want to update the 3.1 packages because they are LTS and are the last version of EF Core that runs on .NET Framework.
Customer Impact
Fixes an AccessViolationException hit my many customers, and avoids every customer having to manually reference the updated package.
How found
Reported by customers.
Test coverage
Sufficient test coverage already exists since this is only an external dependency update.
Regression?
The external bug is a regression from previous versions.
Risk
Low. The new version has been out for a year already with lots of usage, and we already depend on it in 5.0.