Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the non-thread-safety of DbContext more visible #25516

Merged
merged 1 commit into from
Aug 17, 2021
Merged

Conversation

ajcvickers
Copy link
Contributor

Fixes #23319

@ajcvickers ajcvickers requested a review from a team August 14, 2021 09:47
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting this in the summary of each and every public API method seems a bit much - this shows up in the on-hover Intellisense.. We could alternatively just put it in the <remarks> section, which IIRC would show up in the online docs but not clog up all Intellisense.

@ajcvickers
Copy link
Contributor Author

@roji I agree that we have too much in <summary> for some of these docs. Filed #25529 to figure this out.

@ajcvickers ajcvickers merged commit d4dde3c into main Aug 17, 2021
@ajcvickers ajcvickers deleted the ThrSaeadfty0814 branch August 17, 2021 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the non-thread-safety of DbContext more visible
2 participants