Add ToFunction overloads that take a MethodInfo #25437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
reviewed
Aug 6, 2021
| /// <returns> The function configuration builder. </returns> | ||
| public static EntityTypeBuilder ToFunction( | ||
| this EntityTypeBuilder entityTypeBuilder, | ||
| MethodInfo? function) |
There was a problem hiding this comment.
what does null MethodInfo provides? Also it would clash with overload when null value passed.
There was a problem hiding this comment.
Changing it to non-nullable doesn't help to disambiguate null calls, so might as well accept it here.
smitpatel
approved these changes
Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ToViewoverloads for owned typesToInMemoryQueryoverloadsFixes #24611
Fixes #21418
Fixes #24600