Incorporate API Review feedback #25375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
reviewed
Jul 30, 2021
| { | ||
| var extension = OptionsBuilder.Options.FindExtension<InMemoryOptionsExtension>() | ||
| ?? new InMemoryOptionsExtension(); | ||
|
|
||
| extension = extension.WithNullabilityCheckEnabled(nullabilityCheckEnabled); | ||
| extension = extension.WithNullabilityCheckEnabled(nullChecksEnabled); |
There was a problem hiding this comment.
Meh, it’s internal. (I actually did change it, but reverted before sending the PR.)
There was a problem hiding this comment.
Well in that case, I am fine with anything.
smitpatel
reviewed
Jul 30, 2021
| @@ -31,7 +31,7 @@ public void IsRequired_for_property_throws_while_inserting_null_value() | |||
|
|
|||
| var optionsBuilder = new DbContextOptionsBuilder() | |||
| .UseModel(modelBuilder.FinalizeModel()) | |||
| .UseInMemoryDatabase(nameof(NullabilityCheckInMemoryTest), b => b.EnableNullabilityCheck()) | |||
| .UseInMemoryDatabase(nameof(NullabilityCheckInMemoryTest), b => b.EnableNullChecks()) | |||
There was a problem hiding this comment.
may be change nameof arg?
ajcvickers
approved these changes
Aug 1, 2021
|
Hello @bricelam! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #24743