-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Translation for MathF (#18842) #24829
Conversation
|
@smitpatel Should we translate |
If it is easy, sure. |
56e4690
to
be2ab98
Compare
@smitpatel hey, I couldn't find where are the tests for this functionality. |
Needs a new member translator, but it should be pretty easy. Maybe I'll tack it on when merging this PR... (unless @ntovas wants to give it a go first) |
...we should probably file an issue to translate the Cosmos math functions too... |
@bricelam I would like to give to try it, but I will need a bit more context, specially on member translator Also I could make the same fix for CosmosDb |
db4c7d0
to
7c1996f
Compare
Cosmos tests are failing. |
I will look at them and will add any changes, most likely on Saturday, if it's ok for you. |
7c1996f
to
e19152f
Compare
Fixes #18842