Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Update dependencies from dotnet/runtime #24583

Merged
2 commits merged into from
Apr 5, 2021

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Apr 5, 2021

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

  • Subscription: daf314a8-d8c8-4b54-8dcc-08d82e674dfc
  • Build: 20210405.1
  • Date Produced: 4/5/2021 9:15 AM
  • Commit: 95201492e7665c7f21faf42e9d544396ff714497
  • Branch: refs/heads/main

…0405.1

Microsoft.Extensions.Logging , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyModel , System.Diagnostics.DiagnosticSource , System.Collections.Immutable , System.ComponentModel.Annotations
 From Version 6.0.0-preview.4.21178.6 -> To Version 6.0.0-preview.4.21205.1
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving dependency update.

@TanayParikh
Copy link
Contributor

@ajcvickers @smitpatel I'm seeing failures with the DbContextPoolingTest.Double_dispose_does_not_enter_pool_twice test. Is this expected?

@smitpatel
Copy link
Contributor

Based on my tiny research

It seems that dotnet/runtime#50463 introduced a (breaking) change that once scope is disposed it cannot be used again which this particular test does. Either test should be updated or removed.
cc: @davidfowl, @ajcvickers

@TanayParikh
Copy link
Contributor

Thanks @smitpatel! I've created #24590 and skipped the test (0dcc9be) for now. Could I please get a PR approval if that looks good to you?

@ghost
Copy link

ghost commented Apr 5, 2021

Hello @TanayParikh!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented Apr 5, 2021

Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:

  1. Azure Pipelines

These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check.

Give feedback on this
From the bot dev team

We've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments.

Please reach out to us at [email protected] to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin.

@ghost ghost merged commit a130a2f into main Apr 5, 2021
@ghost ghost deleted the darc-main-e88f7462-4c90-41b7-8911-9a1e787bca0f branch April 5, 2021 19:53
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants