Only null non-overlapping FK properties on delete/fixup, if possible #24538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
reviewed
Apr 1, 2021
AndriySvyryd
reviewed
Apr 1, 2021
AndriySvyryd
reviewed
Apr 1, 2021
AndriySvyryd
reviewed
Apr 1, 2021
AndriySvyryd
reviewed
Apr 1, 2021
AndriySvyryd
approved these changes
Apr 1, 2021
Fixes #23883 This is only relevant for overlapping composite foreign keys, where nulling all FK values can also sever other relationships. Since a composite FK is null if any part is null, we avoid nulling the properties that are also shared with another foreign key.
ajcvickers
force-pushed
the
OverlapOverflap0329
branch
from
3512777 to
e34242e
Compare
|
@AndriySvyryd Pushed a new version |
AndriySvyryd
approved these changes
Apr 2, 2021
|
I'll make it an internal extension method. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23883
This is only relevant for overlapping composite foreign keys, where nulling all FK values can also sever other relationships. Since a composite FK is null if any part is null, we avoid nulling the properties that are also shared with another foreign key.