-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add testing for ASP.NET Core Identity model #23723
Conversation
Can you
|
3ba6898
to
6350273
Compare
@smitpatel Done. (Hope I got it all right!) |
test/EFCore.AspNet.InMemory.FunctionalTests/EFCore.AspNet.InMemory.FunctionalTests.csproj
Outdated
Show resolved
Hide resolved
</ItemGroup> | ||
|
||
<ItemGroup> | ||
<ProjectReference Include="..\..\src\EFCore.Relational\EFCore.Relational.csproj" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Specs test generally don't depend on relational. But identity model would be hard to use with non-relational database (except for inmemory), so may be it is fine to leave this as is. There is also an option to add in the name that this is relational specific, like our relational.specs tests. I don't mind either way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was what I discussed a couple of weeks ago in triage. ASP.NET Identity references the relational package, so even if you use Identity with a non-relational provider (like in-memory) there is still a reference to Relational brought in transitively. The idea here is to make sure we reference our build of Relational, and not just happen to use the one from Identity.
test/EFCore.AspNet.Sqlite.FunctionalTests/EFCore.AspNet.Sqlite.FunctionalTests.csproj
Outdated
Show resolved
Hide resolved
test/EFCore.AspNet.Specification.Tests/AspNetIdentityIntKeyTestBase.cs
Outdated
Show resolved
Hide resolved
test/EFCore.AspNet.Specification.Tests/AspNetIdentityDefaultTestBase.cs
Outdated
Show resolved
Hide resolved
Fixes #11838 The intention here is not to test ASP.NET Core Identity. It is instead to test that: * The Identity model continues to build correctly with new versions of EF Core and across multipler providers, including external providers once they adopt these tests * The queries issues by Identity continue to work in new versions and across providers * The common (documented) customizations of the Identity model continue to work
18e702d
to
dfa86ce
Compare
Fixes #11838
The intention here is not to test ASP.NET Core Identity. It is instead to test that: