Add params object array overload to FromSql #1871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
|
||
| for (var index = 0; index < parameters.Count(); index++) | ||
| { | ||
| var parameterName = string.Format("P{0}", index); |
|
Approach looks good. |
|
|
mikary
force-pushed
the
fromSqlParameters
branch
from
6c28b76 to
d8d9706
Compare
| @@ -186,7 +186,20 @@ public virtual Expression VisitRawSqlDerivedTableExpression([NotNull] RawSqlDeri | |||
|
|
|||
| using (_sql.Indent()) | |||
| { | |||
| _sql.AppendLines(rawSqlDerivedTableExpression.Sql); | |||
| var substitutions = new List<string>(); | |||
There was a problem hiding this comment.
nit: You could make this an array as it is fixed size. Then you can avoid the alloc below.
mikary
force-pushed
the
fromSqlParameters
branch
from
d8d9706 to
efb25d4
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm thinking we can normalize the different options (params array, anonymous type, and
Dictionary<string, object>) into a named parameter string in relational (where we have the extensions) and convert to the provider-specific format in the SqlQueryGenerator.This is a first pass with just the
FromSql(string, params object[])extension@anpete @divega