Be explicit about type mappings being available on the finalized model #16178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of #15663 Fixes #14433 The `GetTypeMapping` and `GetRelationalTypeMapping` methods will throw if there isn't a type mapping annotated on the model. Model finalization ensures that this is true. Find methods still exist for cases where they need to be called before the model is finalized, and also so as not to break when not needed. However, see #16177
AndriySvyryd
approved these changes
Jun 20, 2019
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #15662
Fixes #14433
The
GetTypeMappingandGetRelationalTypeMappingmethods will throw if there isn't a type mapping annotated on the model. Model finalization ensures that this is true.Find methods still exist for cases where they need to be called before the model is finalized, and also so as not to break when not needed. However, see #16177