Ensure that ILoggerFactory is re-captured for each context Instance #14783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise the wrong (possibly disposed) logger factory can be used. Fixes part of ASP.NET build break.
|
@bricelam @smitpatel @AndriySvyryd @roji This is to fix a break in ASP.NET, which could also impact real applications, so an expedient review would be appreciated. |
|
Shouldn't it also be reset for pooled contexts? |
AndriySvyryd
approved these changes
Feb 22, 2019
|
@AndriySvyryd Interesting. I'll go check. |
|
Going to merge this now and then look at pooling. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the wrong (possibly disposed) logger factory can be used.
Fixes part of ASP.NET build break.