Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change GetJsonPropertyName to not get the value from the principal #34434

Closed
ajcvickers opened this issue Aug 14, 2024 · 1 comment
Closed

Change GetJsonPropertyName to not get the value from the principal #34434

ajcvickers opened this issue Aug 14, 2024 · 1 comment
Labels
area-json area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
9.0.0

Comments

@ajcvickers
Copy link
Contributor

See #34401 (review)
@ajcvickers ajcvickers mentioned this issue Aug 14, 2024
Merged
@AndriySvyryd
Copy link
Member

Only if the annotation contains null

@AndriySvyryd AndriySvyryd self-assigned this Aug 14, 2024
@AndriySvyryd AndriySvyryd added this to the 9.0.0 milestone Aug 14, 2024
AndriySvyryd added a commit that referenced this issue Sep 5, 2024
@AndriySvyryd
Change GetContainingPropertyName, GetContainerColumnName and GetJsonP…
a1be8d7 
…ropertyName to respect null values set explicitly.

Fixes #34434
@AndriySvyryd AndriySvyryd mentioned this issue Sep 5, 2024
Merged
@AndriySvyryd AndriySvyryd added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Sep 5, 2024
@AndriySvyryd AndriySvyryd removed their assignment Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-json area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
9.0.0
Development

No branches or pull requests
2 participants
@ajcvickers @AndriySvyryd