Sentinel not generated for enums on Optimize-DbContext

[rgordey]

For about the last week, every release of EF Core Preview has had the same result...

public OrderStatus Status { get; set; }

public enum OrderStatus
{
    Entered = 1,
    PaymentReceived = 2,
    Shipped = 3
}

var status = runtimeEntityType.AddProperty(
                "Status",
                typeof(OrderStatus),
                propertyInfo: typeof(SalesOrder).GetProperty("Status", BindingFlags.Public | BindingFlags.Instance | BindingFlags.DeclaredOnly),
                fieldInfo: typeof(SalesOrder).GetField("<Status>k__BackingField", BindingFlags.NonPublic | BindingFlags.Instance | BindingFlags.DeclaredOnly),
                maxLength: 50,
                providerPropertyType: typeof(string),
                sentinel: ); <<== No entry
            status.AddAnnotation("SqlServer:ValueGenerationStrategy", SqlServerValueGenerationStrategy.None);

Include provider and version information

EF Core version: 8.0.0-preview.5.23254.6
Database provider: Microsoft.EntityFrameworkCore.SqlServer
Target framework: .NET 8.0
Operating system: Windows 11
IDE: Visual Studio 2022 17.6

[rgordey]

I tested this last week and it was fixed. But the release today reintroduced/reverted the same problem.

[ajcvickers]

@rgordey What do you mean by, "But the release today?" What version number?

[rgordey]

@ajcvickers 8.0.0-preview.5.23265.4

[ajcvickers]

@ajcvickers I'm not able to reproduce this. With that build, I see the following code generated:

var status = runtimeEntityType.AddProperty(
    "Status",
    typeof(OrderStatus),
    propertyInfo: typeof(Blog).GetProperty("Status", BindingFlags.Public | BindingFlags.Instance | BindingFlags.DeclaredOnly),
    fieldInfo: typeof(Blog).GetField("<Status>k__BackingField", BindingFlags.NonPublic | BindingFlags.Instance | BindingFlags.DeclaredOnly),
    sentinel: (OrderStatus)0);

Can you post a small, complete project with a model that reproduces what you are seeing?

[rgordey]

@ajcvickers ,

I will spin up a sample today.

I suspect it has to do with one convention I am using to save enums as the string value.

protected override void ConfigureConventions(ModelConfigurationBuilder configurationBuilder)
        {
            configurationBuilder.Properties<Enum>()
                .HaveConversion<string>()
                .HaveMaxLength(50);

            configurationBuilder.Properties<string>()
                .HaveMaxLength(100);

            configurationBuilder.Properties<decimal>()
                .HavePrecision(18, 2);
        }

[rgordey]

@ajcvickers,

I figured out my problem while trying to make a sample. I had the [Flags] attribute on the enum. But did not have a 0 value assigned.