Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Obsoletion message for AutoTransactionsEnabled is wrong #29990

Closed
nightcoder62 opened this issue Jan 5, 2023 · 1 comment · Fixed by #29991
Closed

Obsoletion message for AutoTransactionsEnabled is wrong #29990

nightcoder62 opened this issue Jan 5, 2023 · 1 comment · Fixed by #29991
Assignees
@roji
Labels
area-docs closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported Servicing-approved type-bug
Milestone
7.0.3

Comments

@nightcoder62
Copy link

The ObsoleteAttribute says to use EnableAutoTransactions instead, which doesn't exist. It should refer to the AutoTransactionBehavior property instead, perhaps?

Document Details

⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.
@roji roji transferred this issue from dotnet/EntityFramework.Docs Jan 5, 2023
@roji roji transferred this issue from dotnet/EntityFramework.ApiDocs Jan 5, 2023
roji added a commit to roji/efcore that referenced this issue Jan 5, 2023
@roji
Correct [Obsolete] message for AutoTransactionBehavior
9599bb4 
Fixes dotnet#29990
@roji roji mentioned this issue Jan 5, 2023
Merged
@roji
Copy link
Member

roji commented Jan 5, 2023

Thanks, yeah, this API was renamed in an API review, but I forgot to update the [Obsolete] message... Submitted #29991 to fix.

@roji roji self-assigned this Jan 5, 2023
@ghost ghost closed this as completed in #29991 Jan 5, 2023
ghost pushed a commit that referenced this issue Jan 5, 2023
@roji
Correct [Obsolete] message for AutoTransactionBehavior (#29991)
ac98b60 
Fixes #29990
@roji roji added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jan 5, 2023
@roji roji added this to the 8.0.0 milestone Jan 5, 2023
@roji roji changed the title Obsolete attribute recommending nonexistent alternative Obsoletion message for AutoTransactionsEnabled is wrong Jan 5, 2023
@roji roji reopened this Jan 5, 2023
@roji roji removed this from the 8.0.0 milestone Jan 5, 2023
roji added a commit to roji/efcore that referenced this issue Jan 12, 2023
@roji
Correct [Obsolete] message for AutoTransactionBehavior (dotnet#29991)
9a596a9 
Fixes dotnet#29990

(cherry picked from commit ac98b60)
@roji roji mentioned this issue Jan 12, 2023
Merged
roji added a commit to roji/efcore that referenced this issue Jan 12, 2023
@roji
Correct [Obsolete] message for AutoTransactionBehavior
137039b 
Fixes dotnet#29990

(cherry picked from commit ac98b60)
@ajcvickers ajcvickers added this to the 7.0.x milestone Jan 12, 2023
@ajcvickers ajcvickers modified the milestones: 7.0.x, 7.0.3 Jan 12, 2023
@ajcvickers ajcvickers mentioned this issue Feb 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roji roji

Labels
area-docs closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported Servicing-approved type-bug
Projects
None yet
Milestone
7.0.3
Development

Successfully merging a pull request may close this issue.

Correct [Obsolete] message for AutoTransactionBehavior roji/efcore
3 participants
@ajcvickers @roji @nightcoder62