Skip to content

ValueGenerated and ValueGeneratedSensitive have property/entity type swapped in message #29517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ajcvickers opened this issue Nov 9, 2022 · 1 comment · Fixed by #29609
Closed

ValueGenerated and ValueGeneratedSensitive have property/entity type swapped in message #29517

ajcvickers opened this issue Nov 9, 2022 · 1 comment · Fixed by #29609
Labels
area-logging customer-reported good first issue This issue should be relatively straightforward to fix. type-bug
Milestone
8.0.0

Comments

@ajcvickers
Copy link
Contributor

See #29502 (comment)
@ajcvickers ajcvickers self-assigned this Nov 9, 2022
@ajcvickers ajcvickers added the good first issue This issue should be relatively straightforward to fix. label Nov 9, 2022
@tmricardo7
Copy link

In the line

efcore/src/EFCore/Properties/CoreStrings.resx

Line 980 in 089a035

<value>'{contextType}' generated value '{keyValue}' for the property '{3_entityType}.{2_property}'.</value>

The formatter transforms that into
'{0}' generated value '{1}' for the property '{2}.{3}

I don't know if that way to call the variables works to specify the order, the used class is LogValuesFormatter.

This way to format strings using {number}_{variableName} like 1_myProperty is also used in other places of the .resx

ajcvickers added a commit that referenced this issue Nov 18, 2022
@ajcvickers
Fix passing property and entity type names to ValueGenerated messages
035c1fc 
Fixes #29517

Parameter-reordering works for exception messages, but doesn't work for log messages.
Also checked there are no other cases of this.
@ajcvickers ajcvickers mentioned this issue Nov 18, 2022
Merged
@ajcvickers ajcvickers added this to the 8.0.0 milestone Nov 18, 2022
@ajcvickers ajcvickers modified the milestones: 8.0.0, 8.0.0-preview1 Jan 29, 2023
@ajcvickers ajcvickers modified the milestones: 8.0.0-preview1, 8.0.0 Nov 14, 2023
@ajcvickers ajcvickers removed their assignment Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-logging customer-reported good first issue This issue should be relatively straightforward to fix. type-bug
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

Fix passing property and entity type names to ValueGenerated messages dotnet/efcore
2 participants
@ajcvickers @tmricardo7