Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TPC: Allow DbSet for abstract types #27947

Closed
smitpatel opened this issue May 4, 2022 · 0 comments · Fixed by #27988
Closed

TPC: Allow DbSet for abstract types #27947

smitpatel opened this issue May 4, 2022 · 0 comments · Fixed by #27988
Labels
area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
7.0.0

Comments

@smitpatel
Copy link
Contributor

Currently convention sets table name from DbSet name. Mapping an abstract entity type to table in TPC hierarchy throws exception even when the mapping is configured by aforementioned convention. This is disallowing defining DbSet for abstract types.
@smitpatel smitpatel mentioned this issue May 4, 2022
Merged
@ajcvickers ajcvickers added this to the 7.0.0 milestone May 7, 2022
@AndriySvyryd AndriySvyryd removed their assignment May 10, 2022
@AndriySvyryd AndriySvyryd added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label May 10, 2022
AndriySvyryd added a commit that referenced this issue May 10, 2022
@AndriySvyryd
Throw if table-sharing principal is in TPC and has derived types or t…
863a491 
…he dependent doesn't use TPH

Don't configure table name for abstract types in TPC that have a corresponding DbSet property
Make `ToTable(b => {})` map the entity type to the default table

Fixes #3170
Fixes #27608
Fixes #27945
Fixes #27947
AndriySvyryd added a commit that referenced this issue May 10, 2022
@AndriySvyryd
Throw if table-sharing principal is in TPC and has derived types or t…
d67832d 
…he dependent doesn't use TPH

Don't configure table name for abstract types in TPC that have a corresponding DbSet property
Make `ToTable(b => {})` map the entity type to the default table

Fixes #3170
Fixes #27608
Fixes #27945
Fixes #27947
@AndriySvyryd AndriySvyryd mentioned this issue May 10, 2022
Merged
AndriySvyryd added a commit that referenced this issue May 10, 2022
@AndriySvyryd
Throw if table-sharing principal is in TPC and has derived types or t…
6af5d92 
…he dependent doesn't use TPH

Don't configure table name for abstract types in TPC that have a corresponding DbSet property
Make `ToTable(b => {})` map the entity type to the default table

Fixes #3170
Fixes #27608
Fixes #27945
Fixes #27947
AndriySvyryd added a commit that referenced this issue May 11, 2022
@AndriySvyryd
Throw if table-sharing principal is in TPC and has derived types or t…
a6d82d1 
…he dependent doesn't use TPH

Don't configure table name for abstract types in TPC that have a corresponding DbSet property
Make `ToTable(b => {})` map the entity type to the default table

Fixes #3170
Fixes #27608
Fixes #27945
Fixes #27947
AndriySvyryd added a commit that referenced this issue May 11, 2022
@AndriySvyryd
Throw if an entity type in table-sharing uses TPC
979c898 
Don't configure table name for abstract types in TPC that have a corresponding DbSet property
Make ToTable(b => {}) map the entity type to the default table

Fixes #3170
Fixes #27608
Fixes #27945
Fixes #27947
@ajcvickers ajcvickers modified the milestones: 7.0.0, 7.0.0-preview5 May 25, 2022
@smitpatel smitpatel mentioned this issue Jun 9, 2022
Closed
@ajcvickers ajcvickers modified the milestones: 7.0.0-preview5, 7.0.0 Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Throw if an entity type in table-sharing uses TPC dotnet/efcore
3 participants
@ajcvickers @smitpatel @AndriySvyryd