Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ShouldUseSameServiceProvider implementation for empty options #26109

Closed
AndriySvyryd opened this issue Sep 20, 2021 · 0 comments · Fixed by #26111
Closed

Update ShouldUseSameServiceProvider implementation for empty options #26109

AndriySvyryd opened this issue Sep 20, 2021 · 0 comments · Fixed by #26111
Labels
area-infrastructure closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
6.0.0

Comments

@AndriySvyryd
Copy link
Member

AndriySvyryd commented Sep 20, 2021 •
edited
Loading

It should still verify DbContextOptionsExtensionInfo type, otherwise different optionless extensions could still cause a collision if the hash codes of their types happen to be the same.
AndriySvyryd added a commit that referenced this issue Sep 20, 2021
@AndriySvyryd
Add a check to ShouldUseSameServiceProvider even when the extension h…
c954ee6 
…as no options

Fixes #26109
@AndriySvyryd AndriySvyryd mentioned this issue Sep 20, 2021
Merged
@AndriySvyryd AndriySvyryd added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Sep 20, 2021
AndriySvyryd added a commit that referenced this issue Sep 20, 2021
@AndriySvyryd
Add a check to ShouldUseSameServiceProvider even when the extension h…
501c60a 
…as no options

Fixes #26109
@AndriySvyryd AndriySvyryd added this to the 6.0.0 milestone Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-infrastructure closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Add a check to ShouldUseSameServiceProvider even when the extension has no options dotnet/efcore
2 participants
@ajcvickers @AndriySvyryd