Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: Bugs in converting an Apply to a Join #24474

Closed
smitpatel opened this issue Mar 22, 2021 · 0 comments · Fixed by #26011
Closed

Query: Bugs in converting an Apply to a Join #24474

smitpatel opened this issue Mar 22, 2021 · 0 comments · Fixed by #26011
Assignees
@smitpatel
Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
6.0.0

Comments

@smitpatel
Copy link
Contributor

When converting Apply to Join, we currently look at Predicate. But if there is GROUP BY present then predicate after grouping is in Having, further it may not be possible to convert it to join. We need to verify this. Filing this issue to separate out from #17337
@ajcvickers ajcvickers added this to the 6.0.0 milestone Mar 23, 2021
@smitpatel smitpatel mentioned this issue Mar 24, 2021
Closed
@smitpatel smitpatel self-assigned this Sep 13, 2021
smitpatel added a commit that referenced this issue Sep 13, 2021
@smitpatel
Query: Extract join predicate from Having for group by aggregate queries
e1fb717 
Resolves #24474
@smitpatel smitpatel added closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. and removed propose-punt labels Sep 13, 2021
@smitpatel smitpatel mentioned this issue Sep 13, 2021
Merged
smitpatel added a commit that referenced this issue Sep 14, 2021
@smitpatel
Query: Extract join predicate from Having for group by aggregate quer…
a6b7d59 
…ies (#26011)

Resolves #24474
@ajcvickers ajcvickers modified the milestones: 6.0.0, 6.0.0-rc2 Sep 14, 2021
@ajcvickers ajcvickers modified the milestones: 6.0.0-rc2, 6.0.0 Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smitpatel smitpatel

Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Query: Extract join predicate from Having for group by aggregate queries dotnet/efcore
3 participants
@ajcvickers @smitpatel @maumar