Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query work for in-memory provider #16963

Closed
25 tasks done
ajcvickers opened this issue Aug 5, 2019 · 20 comments
Closed
25 tasks done

Query work for in-memory provider #16963

ajcvickers opened this issue Aug 5, 2019 · 20 comments
Assignees
@smitpatel
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
3.0.0

Comments

@ajcvickers
Copy link
Member

ajcvickers commented Aug 5, 2019 •
edited by smitpatel
Loading

Test Failures

Queryable methods pending
@ajcvickers ajcvickers added this to the 3.0.0 milestone Aug 5, 2019
This was referenced Aug 5, 2019
Closed
Closed
@AndriySvyryd
Copy link
Member

Surely one of the assignees will do this work in time for 3.0.0

@ajcvickers
Copy link
Member Author

@AndriySvyryd Surely.

@ajcvickers
Copy link
Member Author

I'm going to try doing this...

ajcvickers added a commit that referenced this issue Aug 7, 2019
@ajcvickers
Reference Include for in-memory provider
5f69edf 
Part of #16963
@ajcvickers ajcvickers mentioned this issue Aug 7, 2019
Merged
ajcvickers added a commit that referenced this issue Aug 7, 2019
@ajcvickers
Reference Include for in-memory provider
06461a1 
Part of #16963
ajcvickers added a commit that referenced this issue Aug 7, 2019
@ajcvickers
Reference Include for in-memory provider
dfd323b 
Part of #16963
@ajcvickers ajcvickers changed the title Implement Include for in-memory provider Query work for in-memory provider Aug 9, 2019
This was referenced Aug 9, 2019
Closed
Closed
@smitpatel
Copy link
Member

@ajcvickers has volunteered to do all the work for InMemory query 🎉

@smitpatel
Copy link
Member

Can you also make sure to update the issue numbers to this one in code base comments for skipped tests?

smitpatel added a commit that referenced this issue Sep 3, 2019
@smitpatel
InMemory: Tests scrub
142b25b 
Update issues references and add area for #16963
Enable tests which are already working
smitpatel added a commit that referenced this issue Sep 3, 2019
@smitpatel
InMemory: Support for Weak/Owned entityTypes
a0c8c44 
Part of #16963
smitpatel added a commit that referenced this issue Sep 3, 2019
@smitpatel
InMemory: Preserve type of value buffer expressions when doing Join/S…
4d01f59 
…electMany

Part of #16963
smitpatel added a commit that referenced this issue Sep 3, 2019
@smitpatel
InMemory: Last cleanup
35f42b6 
Close #16963
@smitpatel smitpatel mentioned this issue Sep 3, 2019
Merged
smitpatel pushed a commit that referenced this issue Sep 3, 2019
@ajcvickers @smitpatel
Support OfType/is in in-memory database
1c188d5 
Part of #16963
smitpatel added a commit that referenced this issue Sep 3, 2019
@smitpatel
InMemory: Avoid N+1 queries for Include
0230d4a 
Don't send shapers to ServerQueryExpression
Laying ground work for collection projection

Part of #16963
smitpatel added a commit that referenced this issue Sep 3, 2019
@smitpatel
InMemory: Add support for collection projection
0b64456 
Part of #16963
smitpatel added a commit that referenced this issue Sep 3, 2019
@smitpatel
InMemory: Test scrub
9b5ab67 
Allow ExpressionTranslator to return null
Fix bug in OfType
Return null for unmapped property to fail gracefully

Part of #16963
smitpatel added a commit that referenced this issue Sep 3, 2019
@smitpatel
InMemory: Support for non-scalar single result in projection
052ecad 
Part of #16963
smitpatel added a commit that referenced this issue Sep 3, 2019
@smitpatel
InMemory: Implement SelectMany
ceea700 
Part of #16963
smitpatel pushed a commit that referenced this issue Sep 3, 2019
@roji @smitpatel
InMemory: Set operations
e46a6e0 
Part of #16963
smitpatel added a commit that referenced this issue Sep 3, 2019
@smitpatel
InMemory: Support for GroupBy aggregate
1746dd0 
Part of #16963

Resolves #9591
smitpatel added a commit that referenced this issue Sep 3, 2019
@smitpatel
InMemory: Support for DefaultIfEmpty
06d4f56 
Part of #16963
smitpatel added a commit that referenced this issue Sep 3, 2019
@smitpatel
InMemory: Some refactorings
5d60090 
Part of #16963
smitpatel added a commit that referenced this issue Sep 3, 2019
@smitpatel
InMemory: Tests scrub
f0c0991 
Update issues references and add area for #16963
Enable tests which are already working
smitpatel added a commit that referenced this issue Sep 3, 2019
@smitpatel
InMemory: Support for Weak/Owned entityTypes
45d61b0 
Part of #16963
smitpatel added a commit that referenced this issue Sep 3, 2019
@smitpatel
InMemory: Preserve type of value buffer expressions when doing Join/S…
89bab67 
…electMany

Part of #16963
@julielerman
Copy link

Wow @smitpatel all the things checked off!! BRAVO! 🥇

@dhhunter
Copy link

dhhunter commented Sep 4, 2019 •
edited
Loading

Yay! Thank you very much @smitpatel, I really love seeing many red unit tests turning green!!!

Unfortunately, not all of them turned green! So here we go:

var blog = context.Blogs
	.Where(x => x.Id == 1)
	.Include(x => x.Posts)
	.Select(b => new BlogDetailsWithCount(b.Id, b.Url, b.Posts
		.Select(p => new PostInfo(p.Id, p.Title)).ToList(), b.Posts.Count))
	.Single();
				
Test method EfCoreSample.BlogTests.CanGetBlogAsDetailsWithCount threw exception: 
System.InvalidCastException: Unable to cast object of type 'System.Linq.Expressions.NewExpression' to type 'System.Linq.Expressions.MethodCallExpression'.
    at Microsoft.EntityFrameworkCore.InMemory.Query.Internal.InMemoryQueryExpression.AddSubqueryProjection(ShapedQueryExpression shapedQueryExpression, Expression& innerShaper)
   at Microsoft.EntityFrameworkCore.InMemory.Query.Internal.InMemoryProjectionBindingExpressionVisitor.Visit(Expression expression)
   at Microsoft.EntityFrameworkCore.InMemory.Query.Internal.InMemoryProjectionBindingExpressionVisitor.VisitNew(NewExpression newExpression)
   at System.Linq.Expressions.NewExpression.Accept(ExpressionVisitor visitor)
   at System.Linq.Expressions.ExpressionVisitor.Visit(Expression node)
   at Microsoft.EntityFrameworkCore.InMemory.Query.Internal.InMemoryProjectionBindingExpressionVisitor.Visit(Expression expression)
   at Microsoft.EntityFrameworkCore.InMemory.Query.Internal.InMemoryProjectionBindingExpressionVisitor.Translate(InMemoryQueryExpression queryExpression, Expression expression)
   at Microsoft.EntityFrameworkCore.InMemory.Query.Internal.InMemoryQueryableMethodTranslatingExpressionVisitor.TranslateSelect(ShapedQueryExpression source, LambdaExpression selector)
   at Microsoft.EntityFrameworkCore.Query.QueryableMethodTranslatingExpressionVisitor.VisitMethodCall(MethodCallExpression methodCallExpression)
   at System.Linq.Expressions.MethodCallExpression.Accept(ExpressionVisitor visitor)
   at System.Linq.Expressions.ExpressionVisitor.Visit(Expression node)
   at Microsoft.EntityFrameworkCore.Query.QueryableMethodTranslatingExpressionVisitor.VisitMethodCall(MethodCallExpression methodCallExpression)
   at System.Linq.Expressions.MethodCallExpression.Accept(ExpressionVisitor visitor)
   at System.Linq.Expressions.ExpressionVisitor.Visit(Expression node)
   at Microsoft.EntityFrameworkCore.Query.QueryCompilationContext.CreateQueryExecutor[TResult](Expression query)
   at Microsoft.EntityFrameworkCore.Storage.Database.CompileQuery[TResult](Expression query, Boolean async)
   at Microsoft.EntityFrameworkCore.Query.Internal.QueryCompiler.CompileQueryCore[TResult](IDatabase database, Expression query, IModel model, Boolean async)
   at Microsoft.EntityFrameworkCore.Query.Internal.QueryCompiler.<>c__DisplayClass9_0`1.<Execute>b__0()
   at Microsoft.EntityFrameworkCore.Query.Internal.CompiledQueryCache.GetOrAddQueryCore[TFunc](Object cacheKey, Func`1 compiler)
   at Microsoft.EntityFrameworkCore.Query.Internal.CompiledQueryCache.GetOrAddQuery[TResult](Object cacheKey, Func`1 compiler)
   at Microsoft.EntityFrameworkCore.Query.Internal.QueryCompiler.Execute[TResult](Expression query)
   at Microsoft.EntityFrameworkCore.Query.Internal.EntityQueryProvider.Execute[TResult](Expression expression)
   at System.Linq.Queryable.Single[TSource](IQueryable`1 source)
   at EfCoreSample.BlogTests.CanGetBlogAsDetailsWithCount() in C:\Users\dhunter\source\repos\ConfigSample\EfCoreSample\BlogTests.cs:line 242
   at EfCoreSample.BlogTests.CanGetBlogAsDetailsWithCount() in C:\Users\dhunter\source\repos\ConfigSample\EfCoreSample\BlogTests.cs:line 252
   at Microsoft.VisualStudio.TestPlatform.MSTestAdapter.PlatformServices.ThreadOperations.ExecuteWithAbortSafety(Action action)

var blogInfo = await context.Blogs
	.Where(x => x.Id == 1)
	.Include(x => x.Posts)
	.Select(x => new BlogInfo(x.Id, x.Url, x.Posts.Count()))
	.SingleAsync();
				
Test method EfCoreSample.BlogTests.CanGetBlogAsInfoByCtorCountExtensionMethod threw exception: 
System.InvalidCastException: Unable to cast object of type 'System.Linq.Expressions.NewExpression' to type 'System.Linq.Expressions.MethodCallExpression'.
    at Microsoft.EntityFrameworkCore.InMemory.Query.Internal.InMemoryQueryExpression.AddSubqueryProjection(ShapedQueryExpression shapedQueryExpression, Expression& innerShaper)
   at Microsoft.EntityFrameworkCore.InMemory.Query.Internal.InMemoryProjectionBindingExpressionVisitor.Visit(Expression expression)
   at Microsoft.EntityFrameworkCore.InMemory.Query.Internal.InMemoryProjectionBindingExpressionVisitor.VisitNew(NewExpression newExpression)
   at System.Linq.Expressions.NewExpression.Accept(ExpressionVisitor visitor)
   at System.Linq.Expressions.ExpressionVisitor.Visit(Expression node)
   at Microsoft.EntityFrameworkCore.InMemory.Query.Internal.InMemoryProjectionBindingExpressionVisitor.Visit(Expression expression)
   at Microsoft.EntityFrameworkCore.InMemory.Query.Internal.InMemoryProjectionBindingExpressionVisitor.Translate(InMemoryQueryExpression queryExpression, Expression expression)
   at Microsoft.EntityFrameworkCore.InMemory.Query.Internal.InMemoryQueryableMethodTranslatingExpressionVisitor.TranslateSelect(ShapedQueryExpression source, LambdaExpression selector)
   at Microsoft.EntityFrameworkCore.Query.QueryableMethodTranslatingExpressionVisitor.VisitMethodCall(MethodCallExpression methodCallExpression)
   at System.Linq.Expressions.MethodCallExpression.Accept(ExpressionVisitor visitor)
   at System.Linq.Expressions.ExpressionVisitor.Visit(Expression node)
   at Microsoft.EntityFrameworkCore.Query.QueryableMethodTranslatingExpressionVisitor.VisitMethodCall(MethodCallExpression methodCallExpression)
   at System.Linq.Expressions.MethodCallExpression.Accept(ExpressionVisitor visitor)
   at System.Linq.Expressions.ExpressionVisitor.Visit(Expression node)
   at Microsoft.EntityFrameworkCore.Query.QueryCompilationContext.CreateQueryExecutor[TResult](Expression query)
   at Microsoft.EntityFrameworkCore.Storage.Database.CompileQuery[TResult](Expression query, Boolean async)
   at Microsoft.EntityFrameworkCore.Query.Internal.QueryCompiler.CompileQueryCore[TResult](IDatabase database, Expression query, IModel model, Boolean async)
   at Microsoft.EntityFrameworkCore.Query.Internal.QueryCompiler.<>c__DisplayClass12_0`1.<ExecuteAsync>b__0()
   at Microsoft.EntityFrameworkCore.Query.Internal.CompiledQueryCache.GetOrAddQueryCore[TFunc](Object cacheKey, Func`1 compiler)
   at Microsoft.EntityFrameworkCore.Query.Internal.CompiledQueryCache.GetOrAddQuery[TResult](Object cacheKey, Func`1 compiler)
   at Microsoft.EntityFrameworkCore.Query.Internal.QueryCompiler.ExecuteAsync[TResult](Expression query, CancellationToken cancellationToken)
   at Microsoft.EntityFrameworkCore.Query.Internal.EntityQueryProvider.ExecuteAsync[TResult](Expression expression, CancellationToken cancellationToken)
   at Microsoft.EntityFrameworkCore.EntityFrameworkQueryableExtensions.ExecuteAsync[TSource,TResult](MethodInfo operatorMethodInfo, IQueryable`1 source, Expression expression, CancellationToken cancellationToken)
   at Microsoft.EntityFrameworkCore.EntityFrameworkQueryableExtensions.ExecuteAsync[TSource,TResult](MethodInfo operatorMethodInfo, IQueryable`1 source, CancellationToken cancellationToken)
   at Microsoft.EntityFrameworkCore.EntityFrameworkQueryableExtensions.SingleAsync[TSource](IQueryable`1 source, CancellationToken cancellationToken)
   at EfCoreSample.BlogTests.CanGetBlogAsInfoByCtorCountExtensionMethod() in C:\Users\dhunter\source\repos\ConfigSample\EfCoreSample\BlogTests.cs:line 79
   at EfCoreSample.BlogTests.CanGetBlogAsInfoByCtorCountExtensionMethod() in C:\Users\dhunter\source\repos\ConfigSample\EfCoreSample\BlogTests.cs:line 86
   at Microsoft.VisualStudio.TestPlatform.MSTestAdapter.PlatformServices.ThreadOperations.ExecuteWithAbortSafety(Action action)

var blogInfo = await context.Blogs
	.Where(x => x.Id == 1)
	.Include(x => x.Posts)
	.Select(x => new BlogInfo(x.Id, x.Url, x.Posts.Count))
	.SingleAsync();
				
Test method EfCoreSample.BlogTests.CanGetBlogAsInfoByCtorCountProperty threw exception: 
System.InvalidCastException: Unable to cast object of type 'System.Linq.Expressions.NewExpression' to type 'System.Linq.Expressions.MethodCallExpression'.
    at Microsoft.EntityFrameworkCore.InMemory.Query.Internal.InMemoryQueryExpression.AddSubqueryProjection(ShapedQueryExpression shapedQueryExpression, Expression& innerShaper)
   at Microsoft.EntityFrameworkCore.InMemory.Query.Internal.InMemoryProjectionBindingExpressionVisitor.Visit(Expression expression)
   at Microsoft.EntityFrameworkCore.InMemory.Query.Internal.InMemoryProjectionBindingExpressionVisitor.VisitNew(NewExpression newExpression)
   at System.Linq.Expressions.NewExpression.Accept(ExpressionVisitor visitor)
   at System.Linq.Expressions.ExpressionVisitor.Visit(Expression node)
   at Microsoft.EntityFrameworkCore.InMemory.Query.Internal.InMemoryProjectionBindingExpressionVisitor.Visit(Expression expression)
   at Microsoft.EntityFrameworkCore.InMemory.Query.Internal.InMemoryProjectionBindingExpressionVisitor.Translate(InMemoryQueryExpression queryExpression, Expression expression)
   at Microsoft.EntityFrameworkCore.InMemory.Query.Internal.InMemoryQueryableMethodTranslatingExpressionVisitor.TranslateSelect(ShapedQueryExpression source, LambdaExpression selector)
   at Microsoft.EntityFrameworkCore.Query.QueryableMethodTranslatingExpressionVisitor.VisitMethodCall(MethodCallExpression methodCallExpression)
   at System.Linq.Expressions.MethodCallExpression.Accept(ExpressionVisitor visitor)
   at System.Linq.Expressions.ExpressionVisitor.Visit(Expression node)
   at Microsoft.EntityFrameworkCore.Query.QueryableMethodTranslatingExpressionVisitor.VisitMethodCall(MethodCallExpression methodCallExpression)
   at System.Linq.Expressions.MethodCallExpression.Accept(ExpressionVisitor visitor)
   at System.Linq.Expressions.ExpressionVisitor.Visit(Expression node)
   at Microsoft.EntityFrameworkCore.Query.QueryCompilationContext.CreateQueryExecutor[TResult](Expression query)
   at Microsoft.EntityFrameworkCore.Storage.Database.CompileQuery[TResult](Expression query, Boolean async)
   at Microsoft.EntityFrameworkCore.Query.Internal.QueryCompiler.CompileQueryCore[TResult](IDatabase database, Expression query, IModel model, Boolean async)
   at Microsoft.EntityFrameworkCore.Query.Internal.QueryCompiler.<>c__DisplayClass12_0`1.<ExecuteAsync>b__0()
   at Microsoft.EntityFrameworkCore.Query.Internal.CompiledQueryCache.GetOrAddQueryCore[TFunc](Object cacheKey, Func`1 compiler)
   at Microsoft.EntityFrameworkCore.Query.Internal.CompiledQueryCache.GetOrAddQuery[TResult](Object cacheKey, Func`1 compiler)
   at Microsoft.EntityFrameworkCore.Query.Internal.QueryCompiler.ExecuteAsync[TResult](Expression query, CancellationToken cancellationToken)
   at Microsoft.EntityFrameworkCore.Query.Internal.EntityQueryProvider.ExecuteAsync[TResult](Expression expression, CancellationToken cancellationToken)
   at Microsoft.EntityFrameworkCore.EntityFrameworkQueryableExtensions.ExecuteAsync[TSource,TResult](MethodInfo operatorMethodInfo, IQueryable`1 source, Expression expression, CancellationToken cancellationToken)
   at Microsoft.EntityFrameworkCore.EntityFrameworkQueryableExtensions.ExecuteAsync[TSource,TResult](MethodInfo operatorMethodInfo, IQueryable`1 source, CancellationToken cancellationToken)
   at Microsoft.EntityFrameworkCore.EntityFrameworkQueryableExtensions.SingleAsync[TSource](IQueryable`1 source, CancellationToken cancellationToken)
   at EfCoreSample.BlogTests.CanGetBlogAsInfoByCtorCountProperty() in C:\Users\dhunter\source\repos\ConfigSample\EfCoreSample\BlogTests.cs:line 94
   at EfCoreSample.BlogTests.CanGetBlogAsInfoByCtorCountProperty() in C:\Users\dhunter\source\repos\ConfigSample\EfCoreSample\BlogTests.cs:line 101
   at Microsoft.VisualStudio.TestPlatform.MSTestAdapter.PlatformServices.ThreadOperations.ExecuteWithAbortSafety(Action action)

var blogInfo = await context.Blogs
	.Where(x => x.Id == 1)
	.Include(x => x.Posts)
	.Select(BlogInfoMapper.Map)
	.SingleAsync();

public class BlogInfoMapper
{
	public static Expression<Func<Blog, BlogInfo>> Map => x => new BlogInfo(x.Id, x.Url, x.Posts.Count);
}
	
Test method EfCoreSample.BlogTests.CanGetBlogAsInfoByMethodCtorMap threw exception: 
System.InvalidCastException: Unable to cast object of type 'System.Linq.Expressions.NewExpression' to type 'System.Linq.Expressions.MethodCallExpression'.
    at Microsoft.EntityFrameworkCore.InMemory.Query.Internal.InMemoryQueryExpression.AddSubqueryProjection(ShapedQueryExpression shapedQueryExpression, Expression& innerShaper)
   at Microsoft.EntityFrameworkCore.InMemory.Query.Internal.InMemoryProjectionBindingExpressionVisitor.Visit(Expression expression)
   at Microsoft.EntityFrameworkCore.InMemory.Query.Internal.InMemoryProjectionBindingExpressionVisitor.VisitNew(NewExpression newExpression)
   at System.Linq.Expressions.NewExpression.Accept(ExpressionVisitor visitor)
   at System.Linq.Expressions.ExpressionVisitor.Visit(Expression node)
   at Microsoft.EntityFrameworkCore.InMemory.Query.Internal.InMemoryProjectionBindingExpressionVisitor.Visit(Expression expression)
   at Microsoft.EntityFrameworkCore.InMemory.Query.Internal.InMemoryProjectionBindingExpressionVisitor.Translate(InMemoryQueryExpression queryExpression, Expression expression)
   at Microsoft.EntityFrameworkCore.InMemory.Query.Internal.InMemoryQueryableMethodTranslatingExpressionVisitor.TranslateSelect(ShapedQueryExpression source, LambdaExpression selector)
   at Microsoft.EntityFrameworkCore.Query.QueryableMethodTranslatingExpressionVisitor.VisitMethodCall(MethodCallExpression methodCallExpression)
   at System.Linq.Expressions.MethodCallExpression.Accept(ExpressionVisitor visitor)
   at System.Linq.Expressions.ExpressionVisitor.Visit(Expression node)
   at Microsoft.EntityFrameworkCore.Query.QueryableMethodTranslatingExpressionVisitor.VisitMethodCall(MethodCallExpression methodCallExpression)
   at System.Linq.Expressions.MethodCallExpression.Accept(ExpressionVisitor visitor)
   at System.Linq.Expressions.ExpressionVisitor.Visit(Expression node)
   at Microsoft.EntityFrameworkCore.Query.QueryCompilationContext.CreateQueryExecutor[TResult](Expression query)
   at Microsoft.EntityFrameworkCore.Storage.Database.CompileQuery[TResult](Expression query, Boolean async)
   at Microsoft.EntityFrameworkCore.Query.Internal.QueryCompiler.CompileQueryCore[TResult](IDatabase database, Expression query, IModel model, Boolean async)
   at Microsoft.EntityFrameworkCore.Query.Internal.QueryCompiler.<>c__DisplayClass12_0`1.<ExecuteAsync>b__0()
   at Microsoft.EntityFrameworkCore.Query.Internal.CompiledQueryCache.GetOrAddQueryCore[TFunc](Object cacheKey, Func`1 compiler)
   at Microsoft.EntityFrameworkCore.Query.Internal.CompiledQueryCache.GetOrAddQuery[TResult](Object cacheKey, Func`1 compiler)
   at Microsoft.EntityFrameworkCore.Query.Internal.QueryCompiler.ExecuteAsync[TResult](Expression query, CancellationToken cancellationToken)
   at Microsoft.EntityFrameworkCore.Query.Internal.EntityQueryProvider.ExecuteAsync[TResult](Expression expression, CancellationToken cancellationToken)
   at Microsoft.EntityFrameworkCore.EntityFrameworkQueryableExtensions.ExecuteAsync[TSource,TResult](MethodInfo operatorMethodInfo, IQueryable`1 source, Expression expression, CancellationToken cancellationToken)
   at Microsoft.EntityFrameworkCore.EntityFrameworkQueryableExtensions.ExecuteAsync[TSource,TResult](MethodInfo operatorMethodInfo, IQueryable`1 source, CancellationToken cancellationToken)
   at Microsoft.EntityFrameworkCore.EntityFrameworkQueryableExtensions.SingleAsync[TSource](IQueryable`1 source, CancellationToken cancellationToken)
   at EfCoreSample.BlogTests.CanGetBlogAsInfoByMethodCtorMap() in C:\Users\dhunter\source\repos\ConfigSample\EfCoreSample\BlogTests.cs:line 148
   at EfCoreSample.BlogTests.CanGetBlogAsInfoByMethodCtorMap() in C:\Users\dhunter\source\repos\ConfigSample\EfCoreSample\BlogTests.cs:line 155
   at Microsoft.VisualStudio.TestPlatform.MSTestAdapter.PlatformServices.ThreadOperations.ExecuteWithAbortSafety(Action action)

@smitpatel smitpatel mentioned this issue Sep 4, 2019
Closed
@smitpatel
Copy link
Member

@dhhunter - Thanks for reporting this. I have filed #17620 to track it. The issue is because of new BlogInfo { } in projection. If you select components of it and then construct object on client side then it should work.

@bricelam bricelam modified the milestones: 3.0.0, 3.0.0-rc1 Sep 16, 2019
@smitpatel smitpatel mentioned this issue Sep 21, 2019
Closed
@ajcvickers ajcvickers modified the milestones: 3.0.0-rc1, 3.0.0 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smitpatel smitpatel

Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
9 participants
@bricelam @ajcvickers @smitpatel @maumar @roji @julielerman @AndriySvyryd @jsheetzati @dhhunter