Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmos: Translate composition over embedded non-primitive collection #16926

Closed
Tracked by #30731
smitpatel opened this issue Aug 3, 2019 · 3 comments · Fixed by #33998
Closed
Tracked by #30731

Cosmos: Translate composition over embedded non-primitive collection #16926

smitpatel opened this issue Aug 3, 2019 · 3 comments · Fixed by #33998
Assignees
Labels
area-cosmos area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone

Comments

@smitpatel
Copy link
Member

        [ConditionalFact]
        public virtual void Navigation_rewrite_on_owned_collection_with_composition()
        {
            using (var ctx = CreateContext())
            {
                var query = ctx.Set<OwnedPerson>().Select(p => p.Orders.Select(o => o.Id != 42).FirstOrDefault());
                var result = query.ToList();

                Assert.Equal(4, result.Count);
            }
        }
@ajcvickers ajcvickers added this to the Backlog milestone Aug 5, 2019
@ajcvickers
Copy link
Member

/cc @AndriySvyryd

@smitpatel smitpatel mentioned this issue Aug 20, 2019
82 tasks
@smitpatel smitpatel changed the title Cosmos: Translate projection over embeded collection Cosmos: Translate composition over embedded collection Dec 31, 2019
@athinadev
Copy link

Please see this too, it should be the same error
#23704

@AndriySvyryd
Copy link
Member

Note to implementer: We would need to create an abstraction to be used in the server query that could represent a scalar, an object or a collection. Only scalars and scalars collections would have type mapping. Shaper must also change to allow composition and this might impact include implementation.

@roji roji assigned roji and unassigned maumar Jun 4, 2024
@roji roji added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jun 4, 2024
@roji roji modified the milestones: Backlog, 9.0.0 Jun 4, 2024
@roji roji removed the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jun 4, 2024
@roji roji changed the title Cosmos: Translate composition over embedded collection Cosmos: Translate composition over embedded non-primitive collection Jun 4, 2024
@roji roji added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jun 15, 2024
roji added a commit to roji/efcore that referenced this issue Jun 15, 2024
roji added a commit to roji/efcore that referenced this issue Jun 15, 2024
roji added a commit to roji/efcore that referenced this issue Jun 15, 2024
roji added a commit to roji/efcore that referenced this issue Jun 15, 2024
@roji roji closed this as completed in 531c238 Jun 20, 2024
@ajcvickers ajcvickers modified the milestones: 9.0.0, 9.0.0-preview6 Jun 21, 2024
@roji roji modified the milestones: 9.0.0-preview6, 9.0.0 Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-cosmos area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants