Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: Avoid anonymous type constants in expression tree #15712

Closed
smitpatel opened this issue May 14, 2019 · 1 comment · Fixed by #17142
Closed

Query: Avoid anonymous type constants in expression tree #15712

smitpatel opened this issue May 14, 2019 · 1 comment · Fixed by #17142
Assignees
@smitpatel
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
3.0.0

Comments

@smitpatel
Copy link
Member

No description provided.

@smitpatel smitpatel mentioned this issue May 15, 2019
Closed
@ajcvickers ajcvickers added this to the 3.0.0 milestone May 17, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0, Backlog Jun 28, 2019
@smitpatel smitpatel removed their assignment Aug 7, 2019
@smitpatel smitpatel mentioned this issue Aug 9, 2019
Closed
@smitpatel smitpatel modified the milestones: Backlog, 3.0.0 Aug 12, 2019
@smitpatel smitpatel self-assigned this Aug 12, 2019
@smitpatel
Copy link
Member Author

Pulled in 3.0. Required for case1 of #17048

smitpatel added a commit that referenced this issue Aug 14, 2019
@smitpatel
Query: Preseve constant based naked Initialization expressions in exp…
c1392d6 
…ression tree

This puts some of the processing (evaluating the expression to the corresponding constant) inside translation pipeline.
- When applying EntityEquality, assumption here is that property is always going to be mapped on server side so we can generate constant.
- When translating newExpression. If the generated constant can be mapped, it would work. (like new Datetime()) else translation would null out.

Resolves #15712
Resolves #17048
Resolves #7983
@smitpatel smitpatel mentioned this issue Aug 14, 2019
Merged
@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Aug 14, 2019
smitpatel added a commit that referenced this issue Aug 14, 2019
@smitpatel
Query: Preseve constant based naked Initialization expressions in exp…
2271170 
…ression tree

This puts some of the processing (evaluating the expression to the corresponding constant) inside translation pipeline.
- When applying EntityEquality, assumption here is that property is always going to be mapped on server side so we can generate constant.
- When translating newExpression. If the generated constant can be mapped, it would work. (like new Datetime()) else translation would null out.

Resolves #15712
Resolves #17048
Resolves #7983
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview9 Aug 21, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0-preview9, 3.0.0 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smitpatel smitpatel

Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

The magical query pipeline dotnet/efcore
2 participants
@ajcvickers @smitpatel