Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Microsoft.Data.Sqlite: Consider changing ultimate fallback type to BLOB #13841

Closed
bricelam opened this issue Sep 7, 2018 · 0 comments · Fixed by #15071
Closed

Microsoft.Data.Sqlite: Consider changing ultimate fallback type to BLOB #13841

bricelam opened this issue Sep 7, 2018 · 0 comments · Fixed by #15071
Assignees
@bricelam
Labels
area-adonet-sqlite breaking-change closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
3.0.0

Comments

@bricelam
Copy link
Contributor

bricelam commented Sep 7, 2018 •
edited
Loading

We have aspnet/Microsoft.Data.Sqlite#435 and aspnet/Microsoft.Data.Sqlite#523 the help improve type inference. We should look for anywhere else that we fallback to a default and make sure they're all consistent. I propose BLOB since every value can be losslessly coerced to it.
@bricelam bricelam self-assigned this Sep 7, 2018
@ajcvickers ajcvickers transferred this issue from aspnet/Microsoft.Data.Sqlite Oct 31, 2018
@ajcvickers ajcvickers added this to the 3.0.0 milestone Oct 31, 2018
@ajcvickers ajcvickers changed the title Consider changing ultimate fallback type to BLOB Microsoft.Data.Sqlite: Consider changing ultimate fallback type to BLOB Oct 31, 2018
@bricelam bricelam mentioned this issue Mar 18, 2019
Merged
@bricelam bricelam added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Mar 18, 2019
bricelam added a commit that referenced this issue Mar 19, 2019
@bricelam
SQLite: Change fallback type to BLOB
f763c6e 
It was previously a mixture of INTEGER and TEXT.

Resolves #13253, resolves #13841
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview4 Apr 15, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0-preview4, 3.0.0 Nov 11, 2019
@bricelam bricelam mentioned this issue Oct 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bricelam bricelam

Labels
area-adonet-sqlite breaking-change closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

SQLite: Change fallback type to BLOB
2 participants
@bricelam @ajcvickers