Remove unchecks in SQL Server type mappings

Closes #30111
dotnet · Jan 28, 2023 · e913f0a · e913f0a
1 parent 8188627
commit e913f0a
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/src/EFCore.SqlServer/Storage/Internal/SqlServerDateTimeOffsetTypeMapping.cs b/src/EFCore.SqlServer/Storage/Internal/SqlServerDateTimeOffsetTypeMapping.cs
@@ -108,7 +108,7 @@ protected override void ConfigureParameter(DbParameter parameter)
         if (Precision.HasValue)
         {
             // Workaround for inconsistent definition of precision/scale between EF and SQLClient for VarTime types
-            parameter.Scale = unchecked((byte)Precision.Value);
+            parameter.Scale = (byte)Precision.Value;
         }
     }
 }
diff --git a/src/EFCore.SqlServer/Storage/Internal/SqlServerDateTimeTypeMapping.cs b/src/EFCore.SqlServer/Storage/Internal/SqlServerDateTimeTypeMapping.cs
@@ -105,7 +105,7 @@ protected override void ConfigureParameter(DbParameter parameter)
         if (Precision.HasValue)
         {
             // Workaround for inconsistent definition of precision/scale between EF and SQLClient for VarTime types
-            parameter.Scale = unchecked((byte)Precision.Value);
+            parameter.Scale = (byte)Precision.Value;
         }
     }
 

diff --git a/src/EFCore.SqlServer/Storage/Internal/SqlServerDecimalTypeMapping.cs b/src/EFCore.SqlServer/Storage/Internal/SqlServerDecimalTypeMapping.cs
@@ -92,12 +92,12 @@ protected override void ConfigureParameter(DbParameter parameter)
 
         if (Precision.HasValue)
         {
-            parameter.Precision = unchecked((byte)Precision.Value);
+            parameter.Precision = (byte)Precision.Value;
         }
 
         if (Scale.HasValue)
         {
-            parameter.Scale = unchecked((byte)Scale.Value);
+            parameter.Scale = (byte)Scale.Value;
         }
     }
 }
diff --git a/src/EFCore.SqlServer/Storage/Internal/SqlServerTimeSpanTypeMapping.cs b/src/EFCore.SqlServer/Storage/Internal/SqlServerTimeSpanTypeMapping.cs
@@ -85,7 +85,7 @@ protected override void ConfigureParameter(DbParameter parameter)
 
         if (Precision.HasValue)
         {
-            parameter.Scale = unchecked((byte)Precision.Value);
+            parameter.Scale = (byte)Precision.Value;
         }
     }
-Original file line number
+Diff line change
@@ Expand Up @@
             if (Precision.HasValue)
             {
-                parameter.Scale = unchecked((byte)Precision.Value);
+                parameter.Scale = (byte)Precision.Value;
             }
         }
@@ Expand Down @@