Migrations: Disable obsolete warnings in designer files

Fixes #8703
dotnet · Jun 7, 2017 · 037755e · 037755e
1 parent b82048c
commit 037755e
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 4 deletions.
diff --git a/src/EFCore.Design/Migrations/Design/CSharpMigrationsGenerator.cs b/src/EFCore.Design/Migrations/Design/CSharpMigrationsGenerator.cs
@@ -151,13 +151,24 @@ public override string GenerateMetadata(
                 {
                     builder
                         .AppendLine("protected override void BuildTargetModel(ModelBuilder modelBuilder)")
-                        .AppendLine("{");
+                        .AppendLine("{")
+                        .DecrementIndent()
+                        .DecrementIndent()
+                        .AppendLine("#pragma warning disable 612, 618")
+                        .IncrementIndent()
+                        .IncrementIndent();
                     using (builder.Indent())
                     {
                         // TODO: Optimize. This is repeated below
                         CSharpDependencies.CSharpSnapshotGenerator.Generate("modelBuilder", targetModel, builder);
                     }
-                    builder.AppendLine("}");
+                    builder
+                        .DecrementIndent()
+                        .DecrementIndent()
+                        .AppendLine("#pragma warning restore 612, 618")
+                        .IncrementIndent()
+                        .IncrementIndent()
+                        .AppendLine("}");
                 }
                 builder.AppendLine("}");
             }
@@ -210,12 +221,23 @@ public override string GenerateSnapshot(
                 {
                     builder
                         .AppendLine("protected override void BuildModel(ModelBuilder modelBuilder)")
-                        .AppendLine("{");
+                        .AppendLine("{")
+                        .DecrementIndent()
+                        .DecrementIndent()
+                        .AppendLine("#pragma warning disable 612, 618")
+                        .IncrementIndent()
+                        .IncrementIndent();
                     using (builder.Indent())
                     {
                         CSharpDependencies.CSharpSnapshotGenerator.Generate("modelBuilder", model, builder);
                     }
-                    builder.AppendLine("}");
+                    builder
+                        .DecrementIndent()
+                        .DecrementIndent()
+                        .AppendLine("#pragma warning restore 612, 618")
+                        .IncrementIndent()
+                        .IncrementIndent()
+                        .AppendLine("}");
                 }
                 builder.AppendLine("}");
             }

diff --git a/test/EFCore.Design.Tests/Migrations/Design/CSharpMigrationsGeneratorTest.cs b/test/EFCore.Design.Tests/Migrations/Design/CSharpMigrationsGeneratorTest.cs
@@ -124,8 +124,10 @@ partial class MyMigration
     {
         protected override void BuildTargetModel(ModelBuilder modelBuilder)
         {
+#pragma warning disable 612, 618
             modelBuilder
                 .HasAnnotation(""Some:EnumValue"", RegexOptions.Multiline);
+#pragma warning restore 612, 618
         }
     }
 }
@@ -198,6 +200,7 @@ partial class MySnapshot : ModelSnapshot
     {
         protected override void BuildModel(ModelBuilder modelBuilder)
         {
+#pragma warning disable 612, 618
             modelBuilder
                 .HasAnnotation(""Some:EnumValue"", RegexOptions.Multiline);
 
@@ -207,6 +210,7 @@ protected override void BuildModel(ModelBuilder modelBuilder)
 
                     b.ToTable(""Cheese"");
                 });
+#pragma warning restore 612, 618
         }
     }
 }