-
Notifications
You must be signed in to change notification settings - Fork 550
Update SDK #1450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SDK #1450
Conversation
|
Hmm looks like the SDK broke something for this repo. |
|
The symptoms look like dotnet/msbuild#4695 but given that it's been marked as fixed, I'm not sure how it's showing up in 5.0 SDK @rainersigwald ? |
|
The SDK you're updating to is built off dotnet/msbuild@e460c00, which didn't yet have the fix (which was committed late in 16.3 after we forked, so the early 16.4 MSBuilds didn't have it). The very latest 5.0 SDKs should have newer MSBuilds with the fix; can you update to newer @JunTaoLuo? There was a little while when MSBuild wasn't flowing to 5.0 because Arcade doesn't support publishing to two channels, but that should be resolved for now. |
|
Ah I see, let me try a new SDK then. |
|
Curious to see if you hit the same test failure as in #1291 |
|
Yup same failures: |
|
@ajcvickers Can someone from your team help take a look at the latest test failures? |
|
FYI @sebastienros |
|
@bricelam any suggestions? @JunTaoLuo you'll probably need to add my dotnet/efcore#18847 changes to get official builds working end-to-end. Might be fastest to do that all together (once you fix the test issue). |
07ffc00 to
e739fc6
Compare
dougbu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JunTaoLuo this is necessary but not sufficient to get official builds working unless this repo uses an old Arcade SDK. See dotnet/efcore#18847
|
Ah I was planning on fixing that in a separate PR since I the disabling of the signing validation is temporary whereas this is a permanent fix. But I suppose I can keep them as separate commits but use the same PR. Will update. |
|
Thanks @JunTaoLuo |
Copy of dotnet/blazor#1929