Skip to content

Conversation

@JunTaoLuo
Copy link
Contributor

@JunTaoLuo JunTaoLuo requested review from a team and BrennanConroy November 6, 2019 23:31
@JunTaoLuo
Copy link
Contributor Author

Hmm looks like the SDK broke something for this repo.

@JunTaoLuo
Copy link
Contributor Author

The symptoms look like dotnet/msbuild#4695 but given that it's been marked as fixed, I'm not sure how it's showing up in 5.0 SDK @rainersigwald ?

@rainersigwald
Copy link
Member

The SDK you're updating to is built off dotnet/msbuild@e460c00, which didn't yet have the fix (which was committed late in 16.3 after we forked, so the early 16.4 MSBuilds didn't have it).

The very latest 5.0 SDKs should have newer MSBuilds with the fix; can you update to newer @JunTaoLuo?

There was a little while when MSBuild wasn't flowing to 5.0 because Arcade doesn't support publishing to two channels, but that should be resolved for now.

@JunTaoLuo
Copy link
Contributor Author

Ah I see, let me try a new SDK then.

@wtgodbe
Copy link
Member

wtgodbe commented Nov 7, 2019

Curious to see if you hit the same test failure as in #1291

@JunTaoLuo
Copy link
Contributor Author

Yup same failures:

System.Resources.MissingManifestResourceException : Could not find the resource \"System.Data.Entity.Properties.Resources.resources\" among the resources \"System.Data.Entity.Resources.Strings.resources\", \"System.Data.Resources.AnnotationSchema.xsd\", \"System.Data.Resources.CodeGenerationSchema.xsd\", \"System.Data.Resources.CSDLSchema_1.xsd\", \"System.Data.Resources.CSDLSchema_1_1.xsd\", \"System.Data.Resources.CSDLSchema_2.xsd\", \"System.Data.Resources.CSDLSchema_3.xsd\", \"System.Data.Resources.EntityStoreSchemaGenerator.xsd\", \"System.Data.Resources.SSDLSchema.xsd\", \"System.Data.Resources.SSDLSchema_2.xsd\", ... embedded in the assembly \"EntityFramework\", nor among the resources in any satellite assemblies for the specified culture. Perhaps the resources were embedded with an incorrect name.

@JunTaoLuo
Copy link
Contributor Author

@ajcvickers Can someone from your team help take a look at the latest test failures?

@JunTaoLuo JunTaoLuo assigned ajcvickers and bricelam and unassigned ajcvickers Nov 8, 2019
@JunTaoLuo
Copy link
Contributor Author

Same test failures encountered in #1291 @bricelam

@JunTaoLuo
Copy link
Contributor Author

FYI @sebastienros

@dougbu
Copy link
Contributor

dougbu commented Nov 11, 2019

@bricelam any suggestions?

@JunTaoLuo you'll probably need to add my dotnet/efcore#18847 changes to get official builds working end-to-end. Might be fastest to do that all together (once you fix the test issue).

@JunTaoLuo
Copy link
Contributor Author

I updated with @bricelam's fix in #1291

Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JunTaoLuo this is necessary but not sufficient to get official builds working unless this repo uses an old Arcade SDK. See dotnet/efcore#18847

@JunTaoLuo
Copy link
Contributor Author

Ah I was planning on fixing that in a separate PR since I the disabling of the signing validation is temporary whereas this is a permanent fix. But I suppose I can keep them as separate commits but use the same PR. Will update.

@dougbu
Copy link
Contributor

dougbu commented Nov 11, 2019

Thanks @JunTaoLuo

@JunTaoLuo JunTaoLuo merged commit 6960589 into master Nov 12, 2019
@JunTaoLuo JunTaoLuo deleted the johluo/sdk branch November 12, 2019 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants