Update to 5.0 SDK #1276
Merged
Update to 5.0 SDK #1276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JunTaoLuo
approved these changes
Sep 19, 2019
dougbu
suggested changes
Sep 19, 2019
| Include="@(KnownFrameworkReference->WithMetadataValue('TargetFramework', 'netcoreapp3.0'))" | ||
| TargetFramework="netcoreapp5.0" | ||
| /> | ||
| </ItemGroup> |
Contributor
There was a problem hiding this comment.
Instead make this logic conditional on lack of %(TargetFramework) == $(DefaultNetCoreTargetFramework) items
Directory.Build.targets
Outdated
|
|
||
| <ItemGroup> | ||
| <!-- Reference base shared framework at incoming dependency flow version, not bundled sdk version. --> | ||
| <FrameworkReference |
Contributor
There was a problem hiding this comment.
Suggest instead updating @(KnownFrameworkReference) items
dougbu
added
the
area-infrastructure
wtgodbe
commented
Sep 19, 2019
Member
Author
|
@dougbu @JunTaoLuo does this look good to go? |
JunTaoLuo
approved these changes
Sep 23, 2019
dougbu
approved these changes
Sep 23, 2019
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/aspnet/AspNetCore-Internal/issues/3016
CC @ajcvickers @JunTaoLuo @dougbu