Skip to content

[release/10.0.1xx] Source code updates from microsoft/vstest#3809

Closed
dotnet-maestro[bot] wants to merge 8 commits intorelease/10.0.1xxfrom
darc-release/10.0.1xx-d5062d1f-b4a3-40f0-8d25-90fa901d7e1e
Closed

[release/10.0.1xx] Source code updates from microsoft/vstest#3809
dotnet-maestro[bot] wants to merge 8 commits intorelease/10.0.1xxfrom
darc-release/10.0.1xx-d5062d1f-b4a3-40f0-8d25-90fa901d7e1e

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Dec 10, 2025

Note

This is a codeflow update. It may contain both source code changes from
the source repo
as well as dependency updates. Learn more here.

This pull request brings the following source code changes

From https://github.com/microsoft/vstest

Diff the source with this PR branch
darc vmr diff --name-only https://github.com/microsoft/vstest:936ecf0f49b8b069215aa7603dcfe5d164f7ef93..https://github.com/dotnet/dotnet:darc-release/10.0.1xx-d5062d1f-b4a3-40f0-8d25-90fa901d7e1e

@dotnet-maestro
Copy link
Contributor Author

<PropertyGroup>
<!-- _git/vs-code-coverage dependencies -->
<MicrosoftInternalCodeCoveragePackageVersion>18.0.0-preview.25469.1</MicrosoftInternalCodeCoveragePackageVersion>
<MicrosoftInternalCodeCoveragePackageVersion>18.0.6</MicrosoftInternalCodeCoveragePackageVersion>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not affect dotnet, this is for VS insertion.

<MicrosoftInternalCodeCoveragePackageVersion>18.0.6</MicrosoftInternalCodeCoveragePackageVersion>
<!-- dotnet/dotnet dependencies -->
<MicrosoftDiagnosticsNETCoreClientPackageVersion>0.2.0-preview.25476.104</MicrosoftDiagnosticsNETCoreClientPackageVersion>
<MicrosoftDiagnosticsNETCoreClientPackageVersion>0.2.0-preview.25479.115</MicrosoftDiagnosticsNETCoreClientPackageVersion>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was automatic update from dotnet/dotnet, so not sure why it blocks the build here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it's pinned here https://github.com/dotnet/dotnet/pull/3809/files#diff-c1b405191bf88ac8d480e5a3b3d223cdb7d21b1580298b2c515d8c9c5e08cb05R9 to a specific version. vstest depends on diagnostics, but the pinning means that the version of diagnostics that is specified is not what the VMR is building, hence the pre-built.

The pinning should be removed for the NETCoreClient package.

avoid introducing pre-builts. https://github.com/dotnet/source-build-reference-packages/tree/main/src/referencePackages/src
-->
<MicrosoftBuildFrameworkPackageVersion>17.8.3</MicrosoftBuildFrameworkPackageVersion>
<MicrosoftBuildFrameworkPackageVersion>17.11.48</MicrosoftBuildFrameworkPackageVersion>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is update for compliance. It has no functional impact on the shipment.

@mmitche
Copy link
Member

mmitche commented Dec 11, 2025

I think we can wait on this. No critical need for 10.0.102

@mmitche
Copy link
Member

mmitche commented Dec 19, 2025

@nohwnd Please take a look at this when you get a chance for 10.0.3

@mmitche
Copy link
Member

mmitche commented Jan 6, 2026

@nohwnd Ping on this.

@nohwnd
Copy link
Member

nohwnd commented Jan 7, 2026

microsoft/vstest#15355 removing the netcore client pinning here.

@nohwnd
Copy link
Member

nohwnd commented Jan 21, 2026

PR on the other side is merged, now it needs to propagate, all other branches (18.3, main) don't have the pinning.

@akoeplinger
Copy link
Member

@nohwnd it looks like the most recent builds on https://dev.azure.com/dnceng/internal/_build?definitionId=1222&_a=summary have been failing for rel/18.0

@nohwnd
Copy link
Member

nohwnd commented Feb 19, 2026

Hopefully will fix after this is merged (it has the changes I had to do on other branches after the new policies #3809 (comment) )

@dotnet-policy-service dotnet-policy-service bot requested a review from a team February 19, 2026 20:21
@akoeplinger
Copy link
Member

akoeplinger commented Feb 24, 2026

there's still an error related to the diagnostics package

@dotnet-maestro
Copy link
Contributor Author

Note

PRs from original repository included in this codeflow update:

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

@dotnet-maestro
Copy link
Contributor Author

Important

While this PR was open, the source repository has received code changes from this repository (an opposite codeflow merged).
To avoid complex conflicts, the codeflow cannot continue until this PR is closed or merged.

You can continue with one of the following options:

  • Ignore this and merge this PR as usual without waiting for the new changes.
    Once merged, Maestro will create a new codeflow PR with the new changes.
  • Close this PR and wait for Maestro to open a new one with old and new changes included.
    You will lose any manual changes made in this PR.
    You can also manually trigger the new codeflow right away by running:
    darc trigger-subscriptions --id e9328371-2231-4e19-8729-a16477127d8e
    
  • Force a codeflow into this PR at your own risk if you want the new changes.
    User commits made to this PR might be reverted.
    darc trigger-subscriptions --id e9328371-2231-4e19-8729-a16477127d8e --force
    

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

@nohwnd nohwnd closed this Feb 25, 2026
@dotnet-maestro dotnet-maestro bot deleted the darc-release/10.0.1xx-d5062d1f-b4a3-40f0-8d25-90fa901d7e1e branch February 25, 2026 12:06
@nohwnd
Copy link
Member

nohwnd commented Feb 25, 2026

triggered new one

@nohwnd
Copy link
Member

nohwnd commented Feb 25, 2026

there's still an error related to the diagnostics package

That is weird, those updates are coming from dotnet/dotnet (not just this PR, but basically we don't touch the rel branch after releasing, only automatic insertions keep updating it). microsoft/vstest#15420

@nohwnd
Copy link
Member

nohwnd commented Feb 25, 2026

#5082 the new PR

@akoeplinger
Copy link
Member

ok looks like #5082 is green :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants