Skip to content

Update DiagnosticPortTests With Delay #9171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wiktork merged 1 commit into from
Apr 2, 2026
Merged

Update DiagnosticPortTests With Delay #9171

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/Tests/Microsoft.Diagnostics.Monitoring.Tool.FunctionalTests/DiagnosticPortTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
using Microsoft.Diagnostics.Monitoring.WebApi;
using System;
using System.IO;
using System.Threading;
using System.Threading.Tasks;
using Xunit;
using Xunit.Abstractions;
Expand Down Expand Up @@ -82,7 +83,7 @@ public async Task DefaultDiagnosticPort_Supported_ListenModeOnNonWindows()

await Task.Delay(TimeSpan.FromSeconds(10)); // Allow some time for the socket to be created.

AssertDefaultDiagnosticPortExists(defaultSharedTempDir);
await AssertDefaultDiagnosticPortExistsAsync(defaultSharedTempDir);
}

/// <summary>
Expand All @@ -109,10 +110,16 @@ private static string GetDefaultSharedSocketPath(string defaultSharedPath)
return Path.Combine(defaultSharedPath, ToolIdentifiers.DefaultSocketName);
}

private static void AssertDefaultDiagnosticPortExists(TemporaryDirectory dir)
private static async Task AssertDefaultDiagnosticPortExistsAsync(TemporaryDirectory dir)
{
string diagnosticPort = GetDefaultSharedSocketPath(dir.FullName);
Assert.True(File.Exists(diagnosticPort), $"Expected socket to exist at '{diagnosticPort}'.");

using CancellationTokenSource cancellationSource = new CancellationTokenSource(CommonTestTimeouts.GeneralTimeout);

while (!File.Exists(diagnosticPort))
{
await Task.Delay(TimeSpan.FromMilliseconds(50), cancellationSource.Token);
}
}

private static void AssertDefaultDiagnosticPortNotExists(TemporaryDirectory dir)
Expand Down
Loading