[Egress] Update StdIn Protocol #4179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
src/Extensions/Microsoft.Diagnostics.Monitoring.Extension.Common/EgressHelper.cs
Outdated
Show resolved
Hide resolved
src/Extensions/Microsoft.Diagnostics.Monitoring.Extension.Common/EgressHelper.cs
Outdated
Show resolved
Hide resolved
wiktork
reviewed
Apr 7, 2023
src/Extensions/Microsoft.Diagnostics.Monitoring.Extension.Common/EgressHelper.cs
Outdated
Show resolved
Hide resolved
wiktork
reviewed
Apr 7, 2023
src/Extensions/Microsoft.Diagnostics.Monitoring.Extension.Common/EgressHelper.cs
Outdated
Show resolved
Hide resolved
wiktork
reviewed
Apr 7, 2023
src/Extensions/Microsoft.Diagnostics.Monitoring.Extension.Common/EgressHelper.cs
Outdated
Show resolved
Hide resolved
kkeirstead
commented
Apr 7, 2023
src/Extensions/Microsoft.Diagnostics.Monitoring.Extension.Common/EgressHelper.cs
Outdated
Show resolved
Hide resolved
kkeirstead
commented
Apr 7, 2023
src/Extensions/Microsoft.Diagnostics.Monitoring.Extension.Common/EgressHelper.cs
Outdated
Show resolved
Hide resolved
src/Extensions/Microsoft.Diagnostics.Monitoring.Extension.Common/EgressHelper.cs
Outdated
Show resolved
Hide resolved
src/Extensions/Microsoft.Diagnostics.Monitoring.Extension.Common/EgressHelper.cs
Outdated
Show resolved
Hide resolved
jander-msft
reviewed
Apr 11, 2023
src/Extensions/Microsoft.Diagnostics.Monitoring.Extension.Common/EgressHelper.cs
Outdated
Show resolved
Hide resolved
kkeirstead
commented
Apr 11, 2023
src/Extensions/Microsoft.Diagnostics.Monitoring.Extension.Common/EgressHelper.cs
Outdated
Show resolved
Hide resolved
jander-msft
reviewed
Apr 11, 2023
src/Extensions/Microsoft.Diagnostics.Monitoring.Extension.Common/EgressHelper.cs
Outdated
Show resolved
Hide resolved
jander-msft
reviewed
Apr 12, 2023
src/Extensions/Microsoft.Diagnostics.Monitoring.Extension.Common/EgressHelper.cs
Outdated
Show resolved
Hide resolved
jander-msft
reviewed
Apr 12, 2023
src/Extensions/Microsoft.Diagnostics.Monitoring.Extension.Common/EgressHelper.cs
Outdated
Show resolved
Hide resolved
jander-msft
reviewed
Apr 13, 2023
src/Extensions/Microsoft.Diagnostics.Monitoring.Extension.Common/EgressHelper.cs
Outdated
Show resolved
Hide resolved
jander-msft
reviewed
Apr 13, 2023
src/Extensions/Microsoft.Diagnostics.Monitoring.Extension.Common/EgressHelper.cs
Outdated
Show resolved
Hide resolved
jander-msft
reviewed
Apr 13, 2023
jander-msft
reviewed
Apr 13, 2023
jander-msft
reviewed
Apr 13, 2023
jander-msft
reviewed
Apr 13, 2023
jander-msft
reviewed
Apr 13, 2023
src/Extensions/Microsoft.Diagnostics.Monitoring.Extension.Common/EgressHelper.cs
Outdated
Show resolved
Hide resolved
jander-msft
reviewed
Apr 13, 2023
src/Extensions/Microsoft.Diagnostics.Monitoring.Extension.Common/EgressHelper.cs
Outdated
Show resolved
Hide resolved
jander-msft
previously approved these changes
Apr 14, 2023
src/Extensions/Microsoft.Diagnostics.Monitoring.Extension.Common/EgressHelper.cs
Show resolved
Hide resolved
jander-msft
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The existing StdIn protocol relied on a newline to separate the
ExtensionEgressPayloadfrom the artifact in the stream; though this worked in most cases, this resulted in empty artifacts being egressed in some edge cases (the belief is that this was a result of Console.ReadLine's buffer). This PR moves away from separating the payload from the artifact via newline, instead specifying the size of the payload at the beginning of the StdIn stream, then reading the exact number of bytes required for the payload (before copying the artifact to the outputStream).Release Notes Entry