Skip to content

Fix Aspire Dashboard product version resolution in update-dependencies #6831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2025
Merged

Fix Aspire Dashboard product version resolution in update-dependencies #6831

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions eng/update-dependencies/AspireBuildUpdaterService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,16 @@ public async Task<int> UpdateFrom(Build build, CreatePullRequestOptions pullRequ
var version = dashboardAssets.First().Version;
var majorMinorVersion = VersionHelper.ResolveMajorMinorVersion(version);

// Known issue: Aspire Dashboard builds are always "preview 1".
// Passing in isStableRelease here keeps us from setting the product
// version to the full build version with the "-preview.1" suffix.
var productVersion = VersionHelper.ResolveProductVersion(version, isStableRelease: true);

List<VariableUpdateInfo> variableUpdates =
[
new VariableUpdateInfo("aspire-dashboard|build-version", version),
new VariableUpdateInfo("aspire-dashboard|product-version", VersionHelper.ResolveProductVersion(version)),
new VariableUpdateInfo("aspire-dashboard|fixed-tag", VersionHelper.ResolveProductVersion(version)),
new VariableUpdateInfo("aspire-dashboard|product-version", productVersion),
new VariableUpdateInfo("aspire-dashboard|fixed-tag", productVersion),
new VariableUpdateInfo("aspire-dashboard|minor-tag", majorMinorVersion.ToString(2)),
new VariableUpdateInfo("aspire-dashboard|major-tag", majorMinorVersion.Major.ToString()),
];
Expand Down